Merge lp://staging/~andrew-haigh-b/cdts/refactor_bug1214896 into lp://staging/cdts
Proposed by
Andrew Haigh
| Status: | Merged |
|---|---|
| Approved by: | Daniel Manrique |
| Approved revision: | 2322 |
| Merged at revision: | 2310 |
| Proposed branch: | lp://staging/~andrew-haigh-b/cdts/refactor_bug1214896 |
| Merge into: | lp://staging/cdts |
| Diff against target: |
1868 lines (+1180/-160) 22 files modified
plainbox-gui/canonical-driver-test-suite/WhiteListModelFactory.cpp (+71/-0) plainbox-gui/canonical-driver-test-suite/WhiteListModelFactory.h (+42/-0) plainbox-gui/canonical-driver-test-suite/canonical-driver-test-suite.pro (+4/-2) plainbox-gui/canonical-driver-test-suite/main.cpp (+56/-76) plainbox-gui/canonical-driver-test-suite/qml/ResumeView.qml (+31/-4) plainbox-gui/canonical-driver-test-suite/qml/RunManagerButtons.qml (+3/-0) plainbox-gui/canonical-driver-test-suite/qml/RunManagerListView.qml (+4/-0) plainbox-gui/canonical-driver-test-suite/qml/TestSelectionListView.qml (+6/-0) plainbox-gui/canonical-driver-test-suite/qml/TestSelectionView.qml (+1/-3) plainbox-gui/canonical-driver-test-suite/qml/WelcomeView.qml (+7/-1) plainbox-gui/canonical-driver-test-suite/qml/canonical-driver-test-suite.qml (+9/-1) plainbox-gui/canonical-driver-test-suite/testitemmodel.cpp (+76/-4) plainbox-gui/canonical-driver-test-suite/testitemmodel.h (+6/-0) plainbox-gui/canonical-driver-test-suite/whitelistitem.h (+5/-0) plainbox-gui/gui-engine/PBJsonUtils.cpp (+71/-0) plainbox-gui/gui-engine/PBJsonUtils.h (+38/-0) plainbox-gui/gui-engine/PBNames.h (+3/-0) plainbox-gui/gui-engine/PBTreeNode.cpp (+16/-0) plainbox-gui/gui-engine/PBTreeNode.h (+3/-0) plainbox-gui/gui-engine/gui-engine.cpp (+648/-67) plainbox-gui/gui-engine/gui-engine.h (+76/-0) plainbox-gui/gui-engine/gui-engine.pro (+4/-2) |
| To merge this branch: | bzr merge lp://staging/~andrew-haigh-b/cdts/refactor_bug1214896 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
The gui now uses the metadata property of the SessionState to preserve its progress as it runs through the tests. This is used to determine whether a resumption of previous test state is possible and gives the user the option of doing so.
Description of the change
A significant amount of code has changed here. The gui now uses the metadata property of the SessionState to preserve its progress as it runs through the tests. This is used to determine whether a resumption of previous test state is possible and gives the user the option of doing so.
Please read the commit log for the full description of the changes required to deliver this feature.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I managed to produce a nice crash with a stale session from an older combination of plainbox and driver-testing, but it went away when I cleared up the session directory, so it's not worth reporting (I'll do it if I see it again).
This looks fine, I've been following evolution of the code and I tested it, things behave mostly as they should, down to setting the last run test to "fail" when the user selects "continue" (we assume that if the test really can't be run, it's because it causes the system to crash, which constitutes a fail).
Thanks!