Merge lp://staging/~andreserl/maas/lp1604901 into lp://staging/~maas-committers/maas/trunk

Proposed by Andres Rodriguez
Status: Merged
Merged at revision: 5191
Proposed branch: lp://staging/~andreserl/maas/lp1604901
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 25 lines (+7/-1)
1 file modified
src/maasserver/api/events.py (+7/-1)
To merge this branch: bzr merge lp://staging/~andreserl/maas/lp1604901
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+300673@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

Looks good to me.

As an aside, I wonder why we chose 1000 as an arbitrary limit. It seems like it would be fine for it to be higher, for ease-of-API-use in support cases.

review: Approve
Revision history for this message
LaMont Jones (lamont) wrote :

I believe that my suggested wording is more in line with other API docstrings.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.