lp://staging/~andreas-pokorny/mir/better-input-device-related-logs
- Get this branch:
- bzr branch lp://staging/~andreas-pokorny/mir/better-input-device-related-logs
Branch merges
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Cemil Azizoglu (community): Approve
- Alexandros Frantzis (community): Needs Fixing
- Alan Griffiths: Abstain
- Kevin DuBois (community): Approve
-
Diff: 115 lines (+39/-6)2 files modifiedsrc/platforms/evdev/platform.cpp (+6/-6)
src/server/input/default_input_device_hub.cpp (+33/-0)
Branch information
Recent revisions
- 3073. By Andreas Pokorny
-
reduce the severity of udev related logs to debug, and provide readable log for new and removed device
- 3072. By Alberto Aguirre
-
fingerpaint: point radius should be a minimum of 1
.
Approved by PS Jenkins bot, Daniel van Vugt, Brandon Schaefer.
- 3071. By Alexandros Frantzis
-
Replace static objects which cause various teardown issues with instance objects. Fixes: https:/
/bugs.launchpad .net/bugs/ 1506137. Approved by Daniel van Vugt, PS Jenkins bot, Kevin DuBois.
- 3070. By Andreas Pokorny
-
Switch to UniqueModulePtr in graphics platform creation symbols
With this the lifetime of the graphics platform shared module is tied to the lifetime of the graphics::Platform instance used by the server. So we can get rid of the global static SharedLibrary in mirserver. This is then identical to the lifetime tracking used for input platforms.
The platform plays factory for Display, PlatformIPCOper
ations and GraphicsBufferA llocator. These instances are still created as plain shared ptrs. Currently DisplayServer guarantees that the Platform outlives those objects, if we dont want to guarantee that destruction ordering we could also use UniqueModulePtr for those - but that requires a slightly larger rework in integration tests. This change also required removing enable_
shared_ from_this from the kms version of mir::graphics: :mesa:: Platform. Capturing a UniqueModulePtr<T> with a shared_ptr<T> works, and also when enable_ shared_ from_this is used in T. It does not work when enable_ shared_ from_this is only added by a class derived from T. - 3068. By Alberto Aguirre
-
Revert -r3066
The server cannot start throwing std::bad_weak_ptr exception.
- 3066. By Andreas Pokorny
-
Switch to UniqueModulePtr in graphics platform creation symbols
With this the lifetime of the graphics platform shared module is tied to the lifetime of the graphics::Platform instance used by the server. So we can get rid of the global static SharedLibrary in mirserver.
The platform plays factory for Display, PlatformIPCOper
ations and GraphicsBufferA llocator. These instances are still created as plain shared ptrs. Currently DisplayServer guarantees that the Platform outlives those objects, if we dont want to guarantee that destruction ordering we could also use UniqueModulePtr for those - but that requires a slightly larger rework in integration tests. - 3065. By Andreas Pokorny
-
Rework Modifier tracking to combine modifiers within
The platform is no longer in charge of the modifier. Instead the new input stack tracks it when the events are received. To reduce the complexity of InputDeviceHub this behavior and similar parts are moved to mir::input::Seat which represents a group of input devices that belong to a user session. (Currently all of them).
Collateral changes:
- allow changing the modifier of MirEvent after creation -> additional symbols to 'hidden' C++ client API
- reduction of EventBuilder interface
- moving of modifier utils to server
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/mir