Terminator

Merge lp://staging/~andrea.corbellini/terminator/fix-392493-2 into lp://staging/terminator/trunk

  1. fix-392493-2
  2. Merge into trunk
Proposed by Andrea Corbellini
Status: Rejected
Rejected by: Chris Jones
Proposed branch: lp://staging/~andrea.corbellini/terminator/fix-392493-2
Merge into: lp://staging/terminator/trunk
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~andrea.corbellini/terminator/fix-392493-2
Reviewer Review Type Date Requested Status
Chris Jones (community) Disapprove
Review via email: mp+7954@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

This is an another way to fix bug 392493: depend on Python >= 2.5 (solution proposed by Chris Jones).

In this branch I have
 * updated terminatorlib to check the interpreter version on import
 * updated the debian package changing the XS-Python-Version field

I don't know how to fix this in the RPM package specification.

Revision history for this message
Chris Jones (cmsj) wrote :

accepted original proposal.

review: Disapprove

Unmerged revisions

757. By Andrea Corbellini

Depend on python >= 2.5 in the debian package.

756. By Andrea Corbellini

Raise RuntimeError when trying to use Terminator with Python << 2.5.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2009-06-23 22:40:55 +0000
3+++ debian/control 2009-06-26 16:47:43 +0000
4@@ -1,6 +1,6 @@
5 Source: terminator
6 Section: misc
7-XS-Python-Version: all
8+XS-Python-Version: >= 2.5
9 Priority: optional
10 Maintainer: Nicolas Valcárcel Scerpella <nvalcarcel@canonical.com>
11 Uploaders: Rudy Godoy Guillén <rudy@debian.org>,
12
13=== modified file 'terminatorlib/__init__.py'
14--- terminatorlib/__init__.py 2009-05-07 00:44:42 +0000
15+++ terminatorlib/__init__.py 2009-06-26 16:47:02 +0000
16@@ -17,3 +17,8 @@
17
18 """Terminator by Chris Jones <cmsj@tenshu.net>"""
19
20+import sys
21+if getattr(sys, 'version_info', (1, 6)) < (2, 4):
22+ raise RuntimeError('Terminator requires Python version 2.5 '
23+ 'or later to run.')
24+