Merge lp://staging/~andrea.corbellini/terminator/fix-1121143 into lp://staging/terminator/trunk

Proposed by Andrea Corbellini
Status: Merged
Merged at revision: 1375
Proposed branch: lp://staging/~andrea.corbellini/terminator/fix-1121143
Merge into: lp://staging/terminator/trunk
Diff against target: 32 lines (+3/-1)
2 files modified
terminatorlib/paned.py (+2/-1)
terminatorlib/window.py (+1/-0)
To merge this branch: bzr merge lp://staging/~andrea.corbellini/terminator/fix-1121143
Reviewer Review Type Date Requested Status
Chris Jones (community) Approve
Review via email: mp+147564@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Jones (cmsj) wrote :

Could you explain why you're removing the del(self) line in paned.py?

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

Because it has no effects: `del' just removes the `self' name from the locals dictionary, and this is something that will be done automatically as soon as the function exits.

When used in this way, `del' acts on local/global names, it does not directly modify the object. In Python there are no ways to force an object to be free()d. There are tecniques to work around this problem, however `del' is not a solution.

Revision history for this message
Andrea Corbellini (andrea.corbellini) wrote :

Also, as long as the instance method does not return, at least a reference count for the object is held by the caller, so you can be 100% sure that if you use `del self' the object will still be alive.

Revision history for this message
Chris Jones (cmsj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.