Merge lp://staging/~andrea-gualano/a4/rotation-sign into lp://staging/a4
Proposed by
Andrea Gualano
| Status: | Merged |
|---|---|
| Merged at revision: | 33 |
| Proposed branch: | lp://staging/~andrea-gualano/a4/rotation-sign |
| Merge into: | lp://staging/a4 |
| Diff against target: |
37 lines (+3/-8) 2 files modified
a4lib/presentation.py (+2/-7) a4lib/region.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~andrea-gualano/a4/rotation-sign |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| leonardo.pecile | Approve | ||
|
Review via email:
|
|||
Commit message
Change rotation sign so that clockwise is positive
Description of the change
A simple refactoring to flip the sign of the rotation property, for consistence.
In both SVG and Cairo, the positive rotation is clockwise (this is because the y axis goes downwards). The render method now applies the inverse rotation, as it does to all other transforms.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
very nice! I like it!