A4

Merge lp://staging/~andrea-gualano/a4/interpolator into lp://staging/a4

Proposed by Andrea Gualano
Status: Merged
Merged at revision: 38
Proposed branch: lp://staging/~andrea-gualano/a4/interpolator
Merge into: lp://staging/a4
Diff against target: 77 lines (+27/-28)
1 file modified
a4lib/region.py (+27/-28)
To merge this branch: bzr merge lp://staging/~andrea-gualano/a4/interpolator
Reviewer Review Type Date Requested Status
Daniele De Luca (community) Approve
A4 Developers Pending
Review via email: mp+29141@code.staging.launchpad.net

Commit message

Pass an interpolator function to customize the animation

Description of the change

This refactoring separates the function used to handle the speed of the animation from the actual computations needed to interpolate each Region attribute.
This should make the animation code more understandable and make it easier to experiment with each kind of interpolation.

While reviewing, please verify that I did not change the effect of Daniele's quadratic function (no change was intended, this is just a refactoring).

To post a comment you must log in.
Revision history for this message
Andrea Gualano (andrea-gualano) wrote :

I found chapters 13 and 14 of Filthy Rich Clients (ISBN 978-0132413930) illuminating on this subject.
Take a look if you can grab a copy.

Revision history for this message
Andrea Gasparini (gaspa) wrote :

It seems ok to me, do you want to wait Daniele to look at it, or can we proceed merging your code?

Revision history for this message
Daniele De Luca (daniele-de-luca) wrote :

Ok for me, merge approved :)

I'm looking for the book right now, maybe I can grub a copy

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches