Merge lp://staging/~andrea-gualano/a4/animations into lp://staging/a4
Proposed by
Andrea Gualano
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 65 | ||||
| Proposed branch: | lp://staging/~andrea-gualano/a4/animations | ||||
| Merge into: | lp://staging/a4 | ||||
| Diff against target: |
307 lines (+176/-37) 4 files modified
a4lib/editor.py (+15/-7) a4lib/player.py (+1/-1) a4lib/region.py (+30/-29) tests/images/regression/597989.svg (+130/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~andrea-gualano/a4/animations | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Gasparini | Approve | ||
|
Review via email:
|
|||
Commit message
Always rotate around Region center, fix #597989
Description of the change
This merge finally introduces the new Region model based on center coordinates (xc,yc) instead of upper left coordinates (x,y).
This also means that:
- all rotations are around a Region's center,
- the rotation widget now rotates round the view center,
- bug #597989 should be fixed.
I think all regressions are fixed, anyway please test that everything is still working.
The code needs some refactoring, but maybe we should do that after merging this?
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
great! :)
I didn't see any particular regression.
About refactoring we need it, yes, but IMHO it's better to merge and do everything we need to release 0.3