Merge lp://staging/~amigadave/gnome-control-center-signon/legal-notice into lp://staging/gnome-control-center-signon

Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 113
Merged at revision: 107
Proposed branch: lp://staging/~amigadave/gnome-control-center-signon/legal-notice
Merge into: lp://staging/gnome-control-center-signon
Diff against target: 203 lines (+130/-4)
5 files modified
Makefile.am (+1/-0)
help/C/legal-notice.page (+93/-0)
help/Makefile.am (+1/-0)
libaccount-plugin/oauth-plugin.c (+12/-2)
src/cc-credentials-accounts-page.vala (+23/-2)
To merge this branch: bzr merge lp://staging/~amigadave/gnome-control-center-signon/legal-notice
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+126387@code.staging.launchpad.net

Description of the change

Add legal notice button to panel UI

* Add draft legal notice
* Add link to online legal notice
* Add legal notice button to AccountsPage
* Add legal notice button to OAuth plugin widget

This will need a UI freeze exception, as it changes the UI and a few translatable strings.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Ugly as hell, but that's how it's designed to be... :-/
Works perfectly anyway, so thanks! :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: