Online Accounts: GNOME Control Center

Merge lp://staging/~amigadave/gnome-control-center-signon/add-account-order into lp://staging/gnome-control-center-signon

  1. add-account-order
  2. Merge into trunk
Proposed by David King
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 111
Merged at revision: 110
Proposed branch: lp://staging/~amigadave/gnome-control-center-signon/add-account-order
Merge into: lp://staging/gnome-control-center-signon
Diff against target: 81 lines (+27/-6)
2 files modified
src/cc-credentials-accounts-model.vala (+11/-6)
src/cc-credentials-accounts-page.vala (+16/-0)
To merge this branch: bzr merge lp://staging/~amigadave/gnome-control-center-signon/add-account-order
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
jenkins (community) continuous-integration Needs Fixing
Review via email: mp+126920@code.staging.launchpad.net

Description of the change

Add new accounts to the bottom of the account list (but above the ‘Add accounts…’ row)

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:110
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/52/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/52/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

The code looks good and delivers the described functionality. But please verify with Calum whether this is actually desired (I'm not sure what problem we are trying to solve -- if it's about visibility of the new account, shouldn't we also select it as well)?

Revision history for this message
David King (amigadave) wrote :

The specification already says “The user’s accounts are listed in the order in which they are created.”, so this is just fixing up some previously-unnoticed behaviour, as before this change the account appeared at the top of the list (which was then sorted correctly after closing and opening the panel).

The UI specification indeed says that “[once] the account is created … information is shown about which applications on the desktop will use the account.” which means that the new account should be selected too. Fixing that should be quite straightforward.

lp://staging/~amigadave/gnome-control-center-signon/add-account-order updated
111. By David King

Select new accounts automatically

The UI specification says that once “the account is created …
information is shown about which applications on the desktop will use
the account.” which means that the newly-created account should be
selected.

Revision history for this message
David King (amigadave) wrote :

This works well for me.

Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:111
http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/53/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/online-accounts-gnome-control-center-ci/./label=quantal/53/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

And for me too :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: