Software Properties

Merge lp://staging/~amichai2/software-properties/edit-on-doubleclick into lp://staging/software-properties

edit-on-doubleclick
Merge into main

Proposed by amichair on 2017-04-30

Status:	Needs review
Proposed branch:	lp://staging/~amichai2/software-properties/edit-on-doubleclick
Merge into:	lp://staging/software-properties
Diff against target:	40 lines (+4/-10) 1 file modified softwareproperties/kde/SoftwarePropertiesKDE.py (+4/-10)
To merge this branch:	bzr merge lp://staging/~amichai2/software-properties/edit-on-doubleclick
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Brian Murray		2017-04-30	Pending
Review via email: mp+323443@code.staging.launchpad.net

Description of the change

Made the edit dialog pop up when double-clicking a source. There were two non-working implementations in the code already, which I replaced with one that works.

Revision history for this message

Brian Murray (brian-murray) wrote on 2017-07-21:

This looks good to me but I'm not really in a position to easily test this change since its KDE. Could you provide some screenshots or video showing how it works? Thanks!

Revision history for this message

amichair (amichai2) wrote on 2017-07-23:

Hi, I don't see how screenshots will help... it looks exactly the same as when you select a source and then click the 'Edit' button. Except you can double-click the source instead of using the button. Nothing is different visually from the current/past behavior.

Revision history for this message

amichair (amichai2) wrote on 2017-10-01:

So, this has been waiting around for months... will it be merged? I was hoping to see it in the upcoming release.

Revision history for this message

amichair (amichai2) wrote on 2017-11-09:

Or the next next release?