Prometheus2 charm

Merge ~aluria/charm-prometheus2:blackbox-exporter-peer-http-endpoint into ~prometheus-charmers/charm-prometheus2:master

  1. Git
  2. lp:~aluria/charm-prometheus2
  3. blackbox-exporter-peer-http-endpoint
  4. Merge into master
Proposed by Alvaro Uria
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: ~aluria/charm-prometheus2:blackbox-exporter-peer-http-endpoint
Merge into: ~prometheus-charmers/charm-prometheus2:master
Diff against target: 414 lines (+303/-12)
3 files modified
metadata.yaml (+2/-0)
reactive/prometheus.py (+266/-8)
templates/prometheus.yml.j2 (+35/-4)
Reviewer Review Type Date Requested Status
Peter Sabaini (community) Needs Fixing
BootStack Reviewers mr tracking; do not claim Pending
BootStack Reviewers Pending
BootStack Reviewers Pending
Canonical IS Reviewers Pending
Review via email: mp+374683@code.staging.launchpad.net

Commit message

Add blackbox-exporter-peer interface

prometheus-blackbox-exporter is used with the "blackbox-exporter" endpoint (http interface) and the "scrape-jobs" juju config parameter. This application runs as non-subordinate (a single unit is expected) to probe multiple external endpoints (http, icmp or others).

prometheus-blackbox-exporter-peer is meant to be used with the "blackbox-exporter-peer" endpoint (http interface). This application runs as subordinate, and makes the prometheus2 charm calculate all cross probes (one blackbox-exporter-peer unit will target its peers). Configuration changes on the exporter-peer units is supported in prometheus2, as well as unit removals and new additions.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Heya,

some comments inline; given the time constraints I don't want to block on them -- however I'm getting a fault running unittests, https://pastebin.canonical.com/p/C5RS5ngm3R/

review: Needs Fixing
Revision history for this message
Alvaro Uria (aluria) wrote :

unittests have not been updated for the changes in this MP. Same errors are hit in the master branch.

Revision history for this message
Alvaro Uria (aluria) wrote :

I've added a few replies to Peter's comments. Thank you for the review.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches