Prometheus Alertmanager Charm

Merge ~aluria/charm-prometheus-alertmanager:blacken-20.08 into ~prometheus-charmers/charm-prometheus-alertmanager:master

  1. Git
  2. lp:~aluria/charm-prometheus-alertmanager
  3. blacken-20.08
  4. Merge into master
Proposed by Alvaro Uria
Status: Merged
Approved by: Giuseppe Petralia
Approved revision: 82a1dae5df027910856dc3eee9e2743924c4d2c8
Merged at revision: 82a1dae5df027910856dc3eee9e2743924c4d2c8
Proposed branch: ~aluria/charm-prometheus-alertmanager:blacken-20.08
Merge into: ~prometheus-charmers/charm-prometheus-alertmanager:master
Prerequisite: ~aluria/charm-prometheus-alertmanager:makefile-20.08
Diff against target: 778 lines (+250/-257)
5 files modified
src/hooks/defaulthook.py (+4/-1)
src/reactive/alertmanager.py (+100/-98)
src/tests/unit/__init__.py (+2/-1)
src/tests/unit/test_reactive_alertmanager.py (+143/-156)
src/tox.ini (+1/-1)
Reviewer Review Type Date Requested Status
Giuseppe Petralia Approve
Paul Goins Approve
Review via email: mp+388737@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Paul Goins (vultaire) wrote :

LGTM.

review: Approve
Revision history for this message
Giuseppe Petralia (peppepetra) wrote :

Make test passes. Code looks good. +1 to merge.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches