Merge ~aluria/charm-prometheus-alertmanager:makefile-20.08 into ~prometheus-charmers/charm-prometheus-alertmanager:master
Proposed by
Alvaro Uria
| Status: | Merged |
|---|---|
| Approved by: | Giuseppe Petralia |
| Approved revision: | a1d3fb54d237fa7bc5be454cc6d7230a5fb41d7a |
| Merged at revision: | a1d3fb54d237fa7bc5be454cc6d7230a5fb41d7a |
| Proposed branch: | ~aluria/charm-prometheus-alertmanager:makefile-20.08 |
| Merge into: | ~prometheus-charmers/charm-prometheus-alertmanager:master |
| Diff against target: |
433 lines (+172/-70) 11 files modified
.gitignore (+24/-14) Makefile (+66/-21) dev/null (+0/-33) interfaces/.empty (+0/-0) layers/.empty (+0/-0) src/hooks/alertmanager-cluster-relation-broken (+1/-0) src/hooks/alertmanager-cluster-relation-changed (+1/-0) src/hooks/alertmanager-cluster-relation-departed (+1/-0) src/hooks/alertmanager-cluster-relation-joined (+1/-0) src/tests/unit/test_reactive_alertmanager.py (+12/-2) src/tox.ini (+66/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Giuseppe Petralia | Approve | ||
| Paul Goins | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM.