charm-openstack-service-checks

Merge ~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1821316-rewrite-03-addtests into ~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1821316-rewrite-02-helpers

  1. Git
  2. lp:~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks
  3. bug/1821316-rewrite-03-addtests
  4. Merge into bug/1821316-rewrite-02-hel...
Proposed by Alvaro Uria
Status: Merged
Merge reported by: Alvaro Uria
Merged at revision: 7b4f9876519eb36feba4f9a0a9a6f286d0731a0f
Proposed branch: ~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1821316-rewrite-03-addtests
Merge into: ~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks:bug/1821316-rewrite-02-helpers
Diff against target: 644 lines (+210/-104)
11 files modified
.gitignore (+19/-10)
Makefile (+17/-17)
dev/null (+0/-12)
src/lib/lib_openstack_service_checks.py (+27/-8)
src/reactive/openstack_service_checks.py (+10/-3)
src/tests/functional/conftest.py (+2/-3)
src/tests/functional/test_deploy.py (+71/-32)
src/tests/unit/conftest.py (+20/-11)
src/tests/unit/requirements.txt (+2/-0)
src/tests/unit/test_lib.py (+40/-7)
src/tox.ini (+2/-1)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Alvaro Uria Pending
Review via email: mp+364969@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alvaro Uria (aluria) wrote :

3 stacked MPs have been requested:
* [1] bug/1821316-rewrite-01-restruct -> master
Integrates template-python-pytests into charm-openstack-service-checks current structure.

* [2] bug/1821316-rewrite-02-helpers -> bug/1821316-rewrite-01-restruct
Moves help functions outside of the reactive script and into lib/.

* [3] bug/1821316-rewrite-03-addtests -> bug/1821316-rewrite-02-helpers
Adds unit and functional tests, as well as fixes bugs found while creating the tests.

1. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364971
2. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364970
3. https://code.launchpad.net/~aluria/charm-openstack-service-checks/+git/charm-openstack-service-checks/+merge/364969

Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. Some inline comments, but I suspect many of them already dealt with from the previous review.

review: Approve
Revision history for this message
Stuart Bishop (stub) wrote :

This was already approved, but I see a minor issue in the new code. I think the 'blocked' status notification to the user when the nrpe relation is missing can be lost, per inline comments, as it only gets set in the install hook and not refreshed in future hooks.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: