Merge lp://staging/~allenap/txlongpollfixture/txlongpoll-script into lp://staging/txlongpollfixture

Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 31
Merged at revision: 31
Proposed branch: lp://staging/~allenap/txlongpollfixture/txlongpoll-script
Merge into: lp://staging/txlongpollfixture
Diff against target: 151 lines (+17/-29)
5 files modified
README (+3/-3)
buildout.cfg (+1/-2)
setup.py (+1/-1)
txlongpollfixture/server.py (+7/-8)
txlongpollfixture/tests/test_server.py (+5/-15)
To merge this branch: bzr merge lp://staging/~allenap/txlongpollfixture/txlongpoll-script
Reviewer Review Type Date Requested Status
Raphaël Badin (community) code* Approve
Review via email: mp+78100@code.staging.launchpad.net

Commit message

Change the name of the twistd script that launches txlongpoll to twistd-for-txlongpoll.

Description of the change

Change the name of the twistd script that launches txlongpoll to twistd-for-txlongpoll, and refer to its path using twistd_bin instead of txlongpoll_bin.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote :

Nice cleanup, it is much better to pass the right path than to rely on the default and fiddle with the path ;).

review: Approve (code*)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: