Code review comment for lp://staging/~allenap/txlongpoll/config-file

Revision history for this message
Raphaƫl Badin (rvb) wrote :

$ ./test txlongpoll.tests.test_plugin | subunit2pyunit
txlongpoll.tests.test_plugin.TestAMQServiceMaker.test_init (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestAMQServiceMaker.test_init ... ok
txlongpoll.tests.test_plugin.TestAMQServiceMaker.test_makeService (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestAMQServiceMaker.test_makeService ... ok
txlongpoll.tests.test_plugin.TestConfig.test_defaults (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_defaults ... ok
txlongpoll.tests.test_plugin.TestConfig.test_load (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_load ... ok
txlongpoll.tests.test_plugin.TestConfig.test_load_example (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_load_example ... ok
txlongpoll.tests.test_plugin.TestConfig.test_option_broker_port_integer (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_option_broker_port_integer ... ERROR
txlongpoll.tests.test_plugin.TestConfig.test_option_frontend_port_integer (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_option_frontend_port_integer ... ERROR
txlongpoll.tests.test_plugin.TestConfig.test_parse (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_parse ... ok
txlongpoll.tests.test_plugin.TestOptions.test_defaults (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestOptions.test_defaults ... ok
txlongpoll.tests.test_plugin.TestOptions.test_parse_minimal_options (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestOptions.test_parse_minimal_options ... ok

======================================================================
ERROR: txlongpoll.tests.test_plugin.TestConfig.test_option_broker_port_integer (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_option_broker_port_integer
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/home/rbadin/canonical/config-file/txlongpoll/tests/test_plugin.py", line 80, in test_option_broker_port_integer
    "broker: port: Please enter an integer value")
  File "/home/rbadin/canonical/config-file/txlongpoll/tests/test_plugin.py", line 75, in check_exception
    Raises(MatchesException(Invalid, message)))
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/testcase.py", line 400, in assertThat
    mismatch = matcher.match(matchee)
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 798, in match
    mismatch = self.exception_matcher.match(exc_info)
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 636, in match
    return self.value_re.match(other[1])
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 1089, in match
    after = self.preprocessor(value)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position 39: ordinal not in range(128)

======================================================================
ERROR: txlongpoll.tests.test_plugin.TestConfig.test_option_frontend_port_integer (subunit.RemotedTestCase)
txlongpoll.tests.test_plugin.TestConfig.test_option_frontend_port_integer
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/home/rbadin/canonical/config-file/txlongpoll/tests/test_plugin.py", line 85, in test_option_frontend_port_integer
    "frontend: port: Please enter an integer value")
  File "/home/rbadin/canonical/config-file/txlongpoll/tests/test_plugin.py", line 75, in check_exception
    Raises(MatchesException(Invalid, message)))
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/testcase.py", line 400, in assertThat
    mismatch = matcher.match(matchee)
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 798, in match
    mismatch = self.exception_matcher.match(exc_info)
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 636, in match
    return self.value_re.match(other[1])
  File "/home/rbadin/canonical/config-file/eggs/testtools-0.9.14-py2.7.egg/testtools/matchers.py", line 1089, in match
    after = self.preprocessor(value)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe8' in position 41: ordinal not in range(128)

----------------------------------------------------------------------
Ran 10 tests in 0.574s

FAILED (errors=2)

« Back to merge proposal