Merge lp://staging/~allenap/storm/interface-rationale-bug-659883 into lp://staging/storm

Proposed by Gavin Panella
Status: Merged
Merged at revision: 378
Proposed branch: lp://staging/~allenap/storm/interface-rationale-bug-659883
Merge into: lp://staging/storm
Diff against target: 37 lines (+27/-0)
1 file modified
storm/zope/interfaces.py (+27/-0)
To merge this branch: bzr merge lp://staging/~allenap/storm/interface-rationale-bug-659883
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Jamu Kakar (community) Approve
Review via email: mp+38924@code.staging.launchpad.net

Commit message

Document the rationale for exposing attributes in IResultSet.

Description of the change

Adds a rationale for which attributes are exposed in the IResultSet interface. This is based on an early comment from jamesh in bug 659883. I think it's a useful thing to document... and will prevent me from filing duplicate bugs in a few months time :)

To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote :

Looks good to me, +1!

review: Approve
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Yes, looks good, merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: