Merge lp://staging/~allenap/maas/force-django16-in-development into lp://staging/~maas-committers/maas/trunk

Proposed by Gavin Panella
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 4333
Merge reported by: Andres Rodriguez
Merged at revision: not available
Proposed branch: lp://staging/~allenap/maas/force-django16-in-development
Merge into: lp://staging/~maas-committers/maas/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
buildout.cfg (+1/-0)
To merge this branch: bzr merge lp://staging/~allenap/maas/force-django16-in-development
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+272967@code.staging.launchpad.net

Commit message

Force the use of Django 1.6 in the development environment.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

What was this doing before this change?

review: Needs Information
Revision history for this message
Gavin Panella (allenap) wrote :

> What was this doing before this change?

When running tests it was fine, because src/maasserver/__init__.py
modifies sys.path to put /usr/lib/django16 near the top. However it
breaks when running regiond (via `make services/regiond/@run`) because
the fix in src/maasserver/__init__.py was coming too late; the system
Django, which is 1.7 on Vivid, had already been imported.

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Okay cool. Thanks for the explanation.

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Download full text (1.0 MiB)

The attempt to merge lp:~allenap/maas/force-django16-in-development into lp:maas failed. Below is the output from the failed tests.

Ign http://nova.clouds.archive.ubuntu.com trusty InRelease
Ign http://security.ubuntu.com trusty-security InRelease
Get:1 http://security.ubuntu.com trusty-security Release.gpg [933 B]
Ign http://nova.clouds.archive.ubuntu.com trusty-updates InRelease
Hit http://nova.clouds.archive.ubuntu.com trusty Release.gpg
Get:2 http://security.ubuntu.com trusty-security Release [63.5 kB]
Get:3 http://nova.clouds.archive.ubuntu.com trusty-updates Release.gpg [933 B]
Hit http://nova.clouds.archive.ubuntu.com trusty Release
Get:4 http://nova.clouds.archive.ubuntu.com trusty-updates Release [63.5 kB]
Hit http://nova.clouds.archive.ubuntu.com trusty/main Sources
Hit http://nova.clouds.archive.ubuntu.com trusty/universe Sources
Get:5 http://security.ubuntu.com trusty-security/main Sources [96.9 kB]
Hit http://nova.clouds.archive.ubuntu.com trusty/main amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com trusty/universe amd64 Packages
Hit http://nova.clouds.archive.ubuntu.com trusty/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com trusty/universe Translation-en
Get:6 http://nova.clouds.archive.ubuntu.com trusty-updates/main Sources [237 kB]
Get:7 http://security.ubuntu.com trusty-security/universe Sources [31.1 kB]
Get:8 http://security.ubuntu.com trusty-security/main amd64 Packages [350 kB]
Get:9 http://nova.clouds.archive.ubuntu.com trusty-updates/universe Sources [139 kB]
Get:10 http://security.ubuntu.com trusty-security/universe amd64 Packages [117 kB]
Get:11 http://nova.clouds.archive.ubuntu.com trusty-updates/main amd64 Packages [627 kB]
Hit http://security.ubuntu.com trusty-security/main Translation-en
Hit http://security.ubuntu.com trusty-security/universe Translation-en
Get:12 http://nova.clouds.archive.ubuntu.com trusty-updates/universe amd64 Packages [320 kB]
Hit http://nova.clouds.archive.ubuntu.com trusty-updates/main Translation-en
Hit http://nova.clouds.archive.ubuntu.com trusty-updates/universe Translation-en
Ign http://nova.clouds.archive.ubuntu.com trusty/main Translation-en_US
Ign http://nova.clouds.archive.ubuntu.com trusty/universe Translation-en_US
Fetched 2,046 kB in 3s (529 kB/s)
Reading package lists...
sudo DEBIAN_FRONTEND=noninteractive apt-get -y \
     --no-install-recommends install apache2 authbind bind9 bind9utils build-essential bzr-builddeb chromium-browser chromium-chromedriver curl daemontools debhelper dh-apport dh-systemd distro-info dnsutils firefox freeipmi-tools git gjs ipython isc-dhcp-common libjs-angularjs libjs-jquery libjs-jquery-hotkeys libjs-yui3-full libjs-yui3-min libpq-dev make nodejs-legacy npm pep8 phantomjs postgresql pyflakes python-apt python-bson python-bzrlib python-convoy python-coverage python-crochet python-cssselect python-curtin python-dev python-distro-info python-django python-django-piston python-django-south python-djorm-ext-pgarray python-docutils python-extras python-fixtures python-flake8 python-formencode python-hivex python-httplib2 python-jinja2 python-jsonschema python-lxml python-mock python-netaddr python-netifaces python-nose python-oaut...

Revision history for this message
Andres Rodriguez (andreserl) wrote :

I don't think we need to do this just now since we are about to release 1.9 and we will be switching to a later django.

Revision history for this message
Gavin Panella (allenap) wrote :

> I don't think we need to do this just now since we are about to
> release 1.9 and we will be switching to a later django.

Do you not want me to QA my own branches? ;)

Revision history for this message
Gavin Panella (allenap) wrote :

I accidentally landed this change via another branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.