Launchpad itself

Merge lp://staging/~allenap/launchpad/ui-convert-dubr-3.0-bug-424410 into lp://staging/launchpad

  1. ui-convert-dubr-3.0-bug-424410
  2. Merge into devel
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~allenap/launchpad/ui-convert-dubr-3.0-bug-424410
Merge into: lp://staging/launchpad
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~allenap/launchpad/ui-convert-dubr-3.0-bug-424410
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Approve
Review via email: mp+11212@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) wrote :

This converts the distribution-upstream-bug-report to 3.0 layout. It was a pretty simple conversion, nothing much needed doing. One test required a tweak because of the new position of the breadcrumbs.

./bin/test -vvct distribution-upstream-bug-report

Lint free.

Revision history for this message
Gavin Panella (allenap) wrote :

To demo this, go to:

  https://bugs.launchpad.dev/ubuntu/+upstreamreport

and:

  https://bugs.launchpad.dev/kubuntu/+upstreamreport

Revision history for this message
Eleanor Berger (intellectronica) wrote :

r=me
ui=me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/stories/distribution/xx-distribution-upstream-bug-report.txt'
2--- lib/lp/bugs/stories/distribution/xx-distribution-upstream-bug-report.txt 2009-08-13 15:12:16 +0000
3+++ lib/lp/bugs/stories/distribution/xx-distribution-upstream-bug-report.txt 2009-09-04 16:28:13 +0000
4@@ -370,6 +370,7 @@
5 >>> print table
6 None
7 >>> content = find_main_content(browser.contents)
8- >>> print extract_text(content)
9+ >>> print extract_text(content.h1)
10 Upstream bug report for Kubuntu
11+ >>> print extract_text(content.find('div', 'top-portlet'))
12 Kubuntu has no bugs filed against it.
13
14=== modified file 'lib/lp/bugs/templates/distribution-upstream-bug-report.pt'
15--- lib/lp/bugs/templates/distribution-upstream-bug-report.pt 2009-07-17 17:59:07 +0000
16+++ lib/lp/bugs/templates/distribution-upstream-bug-report.pt 2009-09-04 16:28:13 +0000
17@@ -1,16 +1,12 @@
18-<html
19+<distribution-upstream-bug-report
20 xmlns="http://www.w3.org/1999/xhtml"
21 xmlns:tal="http://xml.zope.org/namespaces/tal"
22 xmlns:metal="http://xml.zope.org/namespaces/metal"
23 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
24- xml:lang="en"
25- lang="en"
26- dir="ltr"
27- metal:use-macro="view/macro:page/onecolumn"
28- i18n:domain="launchpad"
29->
30+ metal:use-macro="view/macro:page/main_only"
31+ i18n:domain="launchpad">
32
33-<metal:heading fill-slot="head_epilogue">
34+ <metal:heading fill-slot="head_epilogue">
35 <style type="text/css">
36 <!--
37 td.amount a { display: block; }
38@@ -18,66 +14,17 @@
39 tr.bad { background: #ffbfbf; }
40 -->
41 </style>
42-</metal:heading>
43-
44- <body>
45- <metal:portlets fill-slot="portlets">
46- </metal:portlets>
47-
48- <div metal:fill-slot="help">
49- <p>
50- This report gives an overview of how good the bug communication is
51- between a distribution and the upstream projects it produces
52- packages from.
53- </p>
54-
55- <p>
56- Note that many of the counts in the table are linked to
57- corresponding bug listings. The counts may disagree in certain
58- corner cases and those should be verified through <a
59- href="/ubuntu/+addquestion">a Launchpad question</a>. Details on
60- the counts follow.
61- </p>
62-
63- <dl>
64- <dt>Open</dt><dd>Counts unfixed bugs on that package.</dd>
65- <dt>Triaged</dt><dd>Counts unfixed bugs that have been marked as
66- triaged by the official distribution triage team.</dd>
67- <dt>Upstream</dt><dd>Of those bugs triaged, how many indicate they
68- also affect an upstream project. Note that not all bugs filed
69- against a distribution apply to an upstream project, so this
70- percentage will rarely reach 100%.</dd>
71- <dt>Watch</dt><dd>Of the triaged bugs affecting an upstream
72- project, how many have bug watches pointing to remote bug
73- trackers. It is a measure of how well we can monitor progress in
74- the upstream project. The watch column is blank for projects
75- which use Launchpad for bug tracking since it implies that there
76- is already direct communication between distribution and
77- upstream.</dd>
78- <dt>&Delta;</dt><dd>Deltas and percentages are relative to
79- numbers in the previous category; for instance, the delta for
80- watches is the number of upstreamed bugs minus the number of
81- bugs with watches linked.</dd>
82- </dl>
83-
84- <p>
85- The colour green implies healthy activity for that specific value;
86- so a green cell for Triaged means that a good rate of open bugs
87- for that source package have been triaged.
88- </p>
89- <p>
90- The colour red implies data that needs to be filled out in the
91- project registration to allow the upstream bug submission process
92- to work effectively. Links are provided to fix them for users with
93- the appropriate permissions.
94- </p>
95-
96- </div>
97-
98- <div metal:fill-slot="main">
99- <h1>Upstream bug report for
100- <tal:distro replace="context/displayname" /></h1>
101-
102+ </metal:heading>
103+
104+ <div metal:fill-slot="heading">
105+ <h1>
106+ Upstream bug report for
107+ <tal:distro replace="context/displayname" />
108+ </h1>
109+ </div>
110+
111+ <div metal:fill-slot="main">
112+ <div class="top-portlet">
113 <tal:no-bugs tal:condition="not: view/data">
114 <span tal:replace="context/displayname" /> has no bugs filed
115 against it.
116@@ -319,6 +266,6 @@
117 packages listed.</small></div>
118
119 </div>
120+ </div>
121
122- </body>
123-</html>
124+</distribution-upstream-bug-report>