Merge lp://staging/~allenap/launchpad/subs-for-bugtask-bug-656194 into lp://staging/launchpad/db-devel
Proposed by
Gavin Panella
| Status: | Merged |
|---|---|
| Approved by: | Gavin Panella |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 9888 |
| Proposed branch: | lp://staging/~allenap/launchpad/subs-for-bugtask-bug-656194 |
| Merge into: | lp://staging/launchpad/db-devel |
| Diff against target: |
294 lines (+70/-83) 3 files modified
lib/lp/registry/interfaces/structuralsubscription.py (+2/-2) lib/lp/registry/model/structuralsubscription.py (+5/-19) lib/lp/registry/tests/test_structuralsubscriptiontarget.py (+63/-62) |
| To merge this branch: | bzr merge lp://staging/~allenap/launchpad/subs-for-bugtask-bug-656194 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Abel Deuring (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Switch getSusbcription
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
(15:46:23) adeuring: allenap: the changes in your branch look good. But what is the reason for the changes? Do you assume that the SQL query for the old method would be too slow?
(15:48:09) allenap: adeuring: It's easier to select the targets elsewhere, and it's makes the resulting code closer to the existing structural subs code, so it's easier to reuse.
(15:48:47) allenap: adeuring: My follow-on branch is now simpler to implement.
(15:49:50) adeuring: allenap: ok. But now you may get a subscription more than once, if somebody is subscribed to two or more bug targets having bug tasks for a given bug
(15:50:27) allenap: adeuring: That turns out to be a problem. So far :)
(15:50:37) allenap: adeuring: That turns out to *not* be a problem. So far :)
(15:52:35) adeuring: allenap: interesting. But anyway, r=me; the possible duplicate results can be treated later