Launchpad itself

Merge lp://staging/~allenap/launchpad/no-transactions-in-externalbugtracker-bug-564574 into lp://staging/launchpad

  1. no-transactions-in-externalbugtracker-bug-564574
  2. Merge into devel
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~allenap/launchpad/no-transactions-in-externalbugtracker-bug-564574
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~allenap/launchpad/early-batching-limit-bug-509223
Diff against target: 206 lines (+25/-20)
9 files modified
lib/lp/bugs/doc/checkwatches.txt (+1/-1)
lib/lp/bugs/doc/externalbugtracker-bugzilla-api.txt (+2/-1)
lib/lp/bugs/doc/externalbugtracker-bugzilla-lp-plugin.txt (+2/-1)
lib/lp/bugs/doc/externalbugtracker-linking-back.txt (+2/-1)
lib/lp/bugs/doc/externalbugtracker-trac-lp-plugin.txt (+4/-3)
lib/lp/bugs/externalbugtracker/bugzilla.py (+4/-8)
lib/lp/bugs/externalbugtracker/trac.py (+2/-1)
lib/lp/bugs/interfaces/externalbugtracker.py (+3/-2)
lib/lp/bugs/scripts/checkwatches/updater.py (+5/-2)
To merge this branch: bzr merge lp://staging/~allenap/launchpad/no-transactions-in-externalbugtracker-bug-564574
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+23777@code.staging.launchpad.net

Commit message

checkwatches should pass the URL of the local bug to the ISupportsBackLinking implementation. Previously, implementations were forced to compute it as needed, but implementations are forbidden from accessing the database.

Description of the change

Calculate the canonical URL of the local bug in lp.bugs.scripts.checkwatches.updater, not in the lp.bugs.externalbugtracker module, which is forbidden from accessing the database.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good. The only small thing is that our coding standards mandate different indentation for function/method definitions than for invocations:

def arrangeFlowers(self, basket_style, number_of_flowers,
                   colours):
    """Do something nice."""

Jeroen

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.