Go Windows Azure Client Library

Merge lp://staging/~allenap/gwacl/make-gwacl-randy into lp://staging/gwacl

  1. make-gwacl-randy
  2. Merge into trunk
Proposed by Gavin Panella
Status: Merged
Approved by: Gavin Panella
Approved revision: 183
Merged at revision: 182
Proposed branch: lp://staging/~allenap/gwacl/make-gwacl-randy
Merge into: lp://staging/gwacl
Diff against target: 194 lines (+27/-41)
5 files modified
helpers_apiobjects_test.go (+2/-6)
helpers_factory_test.go (+2/-13)
names.go (+1/-20)
names_test.go (+1/-2)
random.go (+21/-0)
To merge this branch: bzr merge lp://staging/~allenap/gwacl/make-gwacl-randy
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Approve
Julian Edwards (community) Approve
Review via email: mp+174432@code.staging.launchpad.net

Commit message

Use a GWACL-specific source of pseudo-randomness.

We use this so we can safely seed it without affecting application-global state in the math package.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Nice one.

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

Looks good! Please have a look at the docstrings of the methods in names.go, you can remove a lot of comments that say things like:
// Be sure your random generator is initialized, or this will always produce
// the same sequence!

review: Approve
lp://staging/~allenap/gwacl/make-gwacl-randy updated
182. By Gavin Panella

Merge trunk.

183. By Gavin Panella

Remove warnings about initialising the random generator.

Revision history for this message
Gavin Panella (allenap) wrote :

> Looks good! Please have a look at the docstrings of the methods in names.go,
> you can remove a lot of comments that say things like:
> // Be sure your random generator is initialized, or this will always produce
> // the same sequence!

Good point, fixed.

Thank you both for your reviews!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: