XPathSelect

Merge lp://staging/~allanlesage/xpathselect/cmake-extras-coverage-reporting into lp://staging/xpathselect

  1. cmake-extras-coverage-reporting
  2. Merge into trunk
Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp://staging/~allanlesage/xpathselect/cmake-extras-coverage-reporting
Merge into: lp://staging/xpathselect
Diff against target: 27 lines (+7/-8)
1 file modified
CMakeLists.txt (+7/-8)
To merge this branch: bzr merge lp://staging/~allanlesage/xpathselect/cmake-extras-coverage-reporting
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Thomi Richards Pending
Review via email: mp+227997@code.staging.launchpad.net

Commit message

Simplify coverage reporting.

Description of the change

Simplify coverage reporting. This won't fail the build but if you have cmake-extras installed you'll get a 'make coverage' target which generates html and xml output.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:44
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~allanlesage/xpathselect/cmake-extras-coverage-reporting/+merge/227997/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/xpathselect-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/xpathselect-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Does this need an additional build-dep? I don't know what 'cmake-extras'
is....

On Thu, Jul 24, 2014 at 9:45 AM, PS Jenkins bot <
<email address hidden>> wrote:

> Review: Needs Fixing continuous-integration
>
> FAILED: Continuous integration, rev:44
> No commit message was specified in the merge proposal. Click on the
> following link and set the commit message (if you want a jenkins rebuild
> you need to trigger it yourself):
>
> https://code.launchpad.net/~allanlesage/xpathselect/cmake-extras-coverage-reporting/+merge/227997/+edit-commit-message
>
> http://jenkins.qa.ubuntu.com/job/xpathselect-ci/9/
> Executed test runs:
> SUCCESS:
> http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-amd64-ci/2
> SUCCESS:
> http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-armhf-ci/2
> SUCCESS: http://jenkins.qa.ubuntu.com/job/xpathselect-utopic-i386-ci/2
>
> Click here to trigger a rebuild:
> http://s-jenkins.ubuntu-ci:8080/job/xpathselect-ci/9/rebuild
>
> --
>
> https://code.launchpad.net/~allanlesage/xpathselect/cmake-extras-coverage-reporting/+merge/227997
> You are requested to review the proposed merge of
> lp:~allanlesage/xpathselect/cmake-extras-coverage-reporting into
> lp:xpathselect.
>

--
Thomi Richards
<email address hidden>

Reply
Revision history for this message
Allan LeSage (allanlesage) wrote :

If you have cmake-extras, lcov, and gcovr installed, you'll get a coverage build target. If you don't, the build won't fail.

$ cmake .. -Denable_coverage=1
$ make
$ make test
$ make coverage

Reply

Unmerged revisions

44. By Allan LeSage

Add our cmake-extras coverage macro.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches