Ubuntu CI Engine

Merge lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment into lp://staging/uci-engine

  1. coverage-extractor-plus-nfss-juju-deployment
  2. Merge into trunk
Proposed by Allan LeSage
Status: Approved
Approved by: Allan LeSage
Approved revision: 863
Proposed branch: lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment
Merge into: lp://staging/uci-engine
Prerequisite: lp://staging/~allanlesage/uci-engine/coverage-extractor
Diff against target: 35 lines (+31/-0)
1 file modified
juju-deployer/coverage-extractor.yaml.tmpl (+31/-0)
To merge this branch: bzr merge lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+238902@code.staging.launchpad.net

Commit message

Deploy coverage-extractor against NFSS.

Description of the change

Initial stab at juju deployment of coverage-extractor, linking to NFSS.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:859
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1619/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1619/rebuild

review: Approve (continuous-integration)
Reply
lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment updated
860. By Allan LeSage

Remove NFSS deployment; we're not using juju relations to communicat with.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:860
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1622/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1622/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Francis Ginther (fginther) wrote :

Comments inline.

review: Needs Fixing
Reply
lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment updated
861. By Allan LeSage

Coverage-extraction deployment details amend for fginther's comments.

Revision history for this message
Allan LeSage (allanlesage) wrote :

Updated, thanks!

Reply
Revision history for this message
Francis Ginther (fginther) wrote :

The indentation is off and needs to be fixed. While that's going on, I can do a test upgrade of my current deployment.

review: Needs Fixing
Reply
lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment updated
862. By Allan LeSage

Correct tabination.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:862
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1630/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1630/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Francis Ginther (fginther) wrote :

As discussed face to face, I think we should change the deployment name in this file from 'ci-airline' to 'ci-engine-coverage' (or something similar). This change will remove this component from the default set deployed with the other engine components and give us the opportunity to land this changes and continue to iterate toward the right solution for the nfss_insert problem.

review: Needs Fixing
Reply
lp://staging/~allanlesage/uci-engine/coverage-extractor-plus-nfss-juju-deployment updated
863. By Allan LeSage

Adjusting deployment name to ci-engine-coverage per fginther's advice.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:863
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1634/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/1634/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Francis Ginther (fginther) wrote :

This solves the immediate problem we saw earlier of not being able to deploy the other ci-engine components. And this allows us to land the deployer file so that it is visible to others and we can consider it in any future deployment changes. The deployment still needs work, but it is not going to block any other work.

review: Approve
Reply
Revision history for this message
Allan LeSage (allanlesage) wrote :

Top-approved given a visual across-the-table thumbs-up from Francis.

Reply

Unmerged revisions

863. By Allan LeSage

Adjusting deployment name to ci-engine-coverage per fginther's advice.

862. By Allan LeSage

Correct tabination.

861. By Allan LeSage

Coverage-extraction deployment details amend for fginther's comments.

860. By Allan LeSage

Remove NFSS deployment; we're not using juju relations to communicat with.

859. By Allan LeSage

Add requests-oauthlib, add quotation marks to coverage-extractor deployment.

858. By Allan LeSage

Initial stab at a juju deployment of coverage-extractor with NFSS.

857. By Allan LeSage

Merge trunk.

856. By Allan LeSage

Extract line and branch coverage from a coverage.xml artifact in swift, post to NFSS.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches