QA Launchpad bug reports

Merge lp://staging/~allanlesage/qlbr/fab-deployment into lp://staging/qlbr

  1. fab-deployment
  2. Merge into trunk
Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp://staging/~allanlesage/qlbr/fab-deployment
Merge into: lp://staging/qlbr
Diff against target: 669 lines (+613/-0)
11 files modified
DEPLOYING (+70/-0)
deployment/crontab-sample (+2/-0)
deployment/pg_hba.conf (+99/-0)
deployment/ports.conf (+20/-0)
deployment/production_settings.py (+24/-0)
deployment/qlbr-staging.conf (+37/-0)
deployment/qlbr-testing.conf (+37/-0)
deployment/qlbr.conf (+37/-0)
deployment/staging_settings.py (+24/-0)
deployment/testing_settings.py (+24/-0)
fabfile.py (+239/-0)
To merge this branch: bzr merge lp://staging/~allanlesage/qlbr/fab-deployment
Reviewer Review Type Date Requested Status
Max Brustkern (community) Needs Information
Review via email: mp+197446@code.staging.launchpad.net

Commit message

Use fabric to deploy qlbr as described in the DEPLOYMENT doc.

Description of the change

Use fabric to deploy qlbr as described in the DEPLOYMENT doc.

To post a comment you must log in.
Revision history for this message
Allan LeSage (allanlesage) wrote :

Max I'll test the `bzr export` method you suggested, one sec.

Reply
lp://staging/~allanlesage/qlbr/fab-deployment updated
65. By Allan LeSage

Make crontab_filepath mandatory.

Revision history for this message
Allan LeSage (allanlesage) wrote :

So I'm not able to get the export to work out of the box, going to leave as-is and pick that up in a bug if you don't mind Max?

Reply
Revision history for this message
Max Brustkern (nuclearbob) wrote :

> So I'm not able to get the export to work out of the box, going to leave as-is
> and pick that up in a bug if you don't mind Max?

Works for me, we can make a bug or add it to the blueprint.

On merge line 13, I like to have sudo before all recommended apt-get commands. That makes me feel more ubuntu-y. I also wonder if maybe adding the $ prompt to other command recommendations is a good idea. We can do that in another merge, though.

Do we want to mention something about the REPLACE_ME stuff in deployment/production_settings.py, staging_settings.py, and testing_settings.py?

Have you tested deploy_crontab? It seems like crontab_filename and crontab_filepath maybe ought to be the same? I also wonder if it would make sense to have a default available so we can automatically deploy the recommended one, but it seems like the most recent commit did away with that, so I'm guessing there's a reason.

On line 529 of the merge, is lp:helipad what we want, or is that left over from a previous project?

review: Needs Information
Reply
lp://staging/~allanlesage/qlbr/fab-deployment updated
66. By Allan LeSage

nuclearbob-recommended changes, having tested each.

Unmerged revisions

66. By Allan LeSage

nuclearbob-recommended changes, having tested each.

65. By Allan LeSage

Make crontab_filepath mandatory.

64. By Allan LeSage

Added some deployment documentation.

63. By Allan LeSage

Merged trunk.

62. By Allan LeSage

Minor clarification to instructions.

61. By Allan LeSage

Attempt at crontab operations.

60. By Allan LeSage

Merged trunk.

59. By Allan LeSage

Merged trunk.

58. By Allan LeSage

Add launchpadlib cache dir to deployments.

57. By Allan LeSage

Remove an unused mako import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: