Merge lp://staging/~allanlesage/qlbr/bug-title-textfield into lp://staging/qlbr

Proposed by Allan LeSage
Status: Merged
Approved by: Max Brustkern
Approved revision: 50
Merged at revision: 51
Proposed branch: lp://staging/~allanlesage/qlbr/bug-title-textfield
Merge into: lp://staging/qlbr
Diff against target: 13 lines (+2/-1)
1 file modified
qlbr/models.py (+2/-1)
To merge this branch: bzr merge lp://staging/~allanlesage/qlbr/bug-title-textfield
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+195995@code.staging.launchpad.net

Commit message

Make Bug.title a TextField to accommodate apport-reported bugs.

Description of the change

Encountered lp:1226595 which was crashing get_task_data. In addition to this we need some tests for django.db.DatabaseError being thrown in the middle of that code but I'm going to save that for a bit. Note that this doesn't show up locally because sqlite3 doesn't enforce the max_length limits--this is a "postgres thing". Also according to dobey in #launchpad there's no hard limit to the bug.title field, except possibly the theoretical postgres limit for UNICODE.

tl;dr--make bug.title a TextField.

To post a comment you must log in.
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good. Is there any particular reason why most of them shouldn't be TextField? I just used CharField since that was what I saw in a tutorial.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: