qa-coverage-dashboard

Merge lp://staging/~allanlesage/qa-coverage-dashboard/simplify-extractor-split-out-get-last-build into lp://staging/qa-coverage-dashboard

  1. simplify-extractor-split-out-get-last-build
  2. Merge into trunk
Proposed by Allan LeSage
Status: Merged
Approved by: Chris Gagnon
Approved revision: 768
Merged at revision: 775
Proposed branch: lp://staging/~allanlesage/qa-coverage-dashboard/simplify-extractor-split-out-get-last-build
Merge into: lp://staging/qa-coverage-dashboard
Diff against target: 687 lines (+72/-558)
4 files modified
gaps/tests/__init__.py (+3/-0)
gaps/tests/test_add.py (+44/-0)
gaps/util/add.py (+17/-9)
gaps/util/extractor.py (+8/-549)
To merge this branch: bzr merge lp://staging/~allanlesage/qa-coverage-dashboard/simplify-extractor-split-out-get-last-build
Reviewer Review Type Date Requested Status
Chris Gagnon (community) Approve
Review via email: mp+216934@code.staging.launchpad.net

Description of the change

Split out the get_last_build function and add a test for it individually, also chop down the olde extractor.

To post a comment you must log in.
lp://staging/~allanlesage/qa-coverage-dashboard/simplify-extractor-split-out-get-last-build updated
768. By Allan LeSage

Merged trunk, resolving conflicts.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

looks good

Revision history for this message
Chris Gagnon (chris.gagnon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: