qa-coverage-dashboard

Merge lp://staging/~allanlesage/qa-coverage-dashboard/logging-only into lp://staging/qa-coverage-dashboard

  1. logging-only
  2. Merge into trunk
Proposed by Allan LeSage
Status: Merged
Approved by: Chris Gagnon
Approved revision: 767
Merged at revision: 767
Proposed branch: lp://staging/~allanlesage/qa-coverage-dashboard/logging-only
Merge into: lp://staging/qa-coverage-dashboard
Diff against target: 124 lines (+14/-16)
3 files modified
gaps/tests/test_jenkins_pull.py (+3/-4)
gaps/util/add.py (+3/-4)
gaps/util/jenkins_pull.py (+8/-8)
To merge this branch: bzr merge lp://staging/~allanlesage/qa-coverage-dashboard/logging-only
Reviewer Review Type Date Requested Status
Chris Gagnon (community) Approve
Review via email: mp+216496@code.staging.launchpad.net

Description of the change

Straightforwardly remove the prints.

To post a comment you must log in.
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I don't think you meant to delete this

47 -from jenkinsapi import (
48 - #api,
49 - build,
50 - job,
51 -)

review: Needs Fixing
lp://staging/~allanlesage/qa-coverage-dashboard/logging-only updated
767. By Allan LeSage

Add imports to fix failing tests :/ .

Revision history for this message
Allan LeSage (allanlesage) wrote :

Deleted the above to satisfy flake8, corrected with proper import in test instead.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: