Merge lp://staging/~allanlesage/qa-coverage-dashboard/jenkinsapi-singleton into lp://staging/qa-coverage-dashboard
Proposed by
Allan LeSage
Status: | Merged |
---|---|
Approved by: | Chris Gagnon |
Approved revision: | 771 |
Merged at revision: | 774 |
Proposed branch: | lp://staging/~allanlesage/qa-coverage-dashboard/jenkinsapi-singleton |
Merge into: | lp://staging/qa-coverage-dashboard |
Diff against target: |
88 lines (+24/-15) 2 files modified
gaps/tests/test_jenkins_pull.py (+10/-10) gaps/util/jenkins_pull.py (+14/-5) |
To merge this branch: | bzr merge lp://staging/~allanlesage/qa-coverage-dashboard/jenkinsapi-singleton |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brendan Donegan (community) | Approve | ||
Chris Gagnon (community) | Approve | ||
Review via email:
|
Description of the change
The public Jenkins is really really slow so don't login every time, just login once!
To post a comment you must log in.
This looks good except for a pep8 issue
68 + if JENKINSAPI_JENKINS == None:
should be
if JENKINSAPI_JENKINS is None: