Merge lp://staging/~allanlesage/kubuntu-packaging/qtlocation-amend-test-enablement into lp://staging/~kubuntu-packagers/kubuntu-packaging/qtlocation-opensource-src

Proposed by Allan LeSage
Status: Merged
Merged at revision: 51
Proposed branch: lp://staging/~allanlesage/kubuntu-packaging/qtlocation-amend-test-enablement
Merge into: lp://staging/~kubuntu-packagers/kubuntu-packaging/qtlocation-opensource-src
Diff against target: 282 lines (+16/-210)
5 files modified
debian/changelog (+2/-3)
debian/patches/enable_coverage_reporting.patch (+0/-156)
debian/patches/series (+0/-1)
debian/patches/skip_failing_tests.patch (+12/-47)
debian/rules (+2/-3)
To merge this branch: bzr merge lp://staging/~allanlesage/kubuntu-packaging/qtlocation-amend-test-enablement
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Review via email: mp+200903@code.staging.launchpad.net

Description of the change

Sorry to make us do this again but a review of changes to qt3d made me want to clean up my earlier changes to qtlocation.

I'm aware that some tests were failing specifically on arm but I don't have an environment to reproduce those failures; I propose to try under this new method to see if there's improvement.

Also note that we're setting aside the coverage bit as we'll just apply the necessary changes during a Jenkins build.

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Hi. Armhf still fails a bit:

https://launchpadlibrarian.net/162911783/buildlog_ubuntu-trusty-armhf.qtlocation-opensource-src_5.2.0-0ubuntu1~trusty1~test9_FAILEDTOBUILD.txt.gz

But I'll merge this anyhow and do test disabling those three tests that are failing to see if it then is ok.

review: Approve
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

As an update, it was enough to disable the three individual tests and now tests pass also on arm.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches