autopilot-gtk

Merge lp://staging/~allanlesage/autopilot-gtk/suggested-matching-fix-changes into lp://staging/~dbarth/autopilot-gtk/matching-fix

  1. suggested-matching-fix-changes
  2. Merge into matching-fix
Proposed by Allan LeSage
Status: Needs review
Proposed branch: lp://staging/~allanlesage/autopilot-gtk/suggested-matching-fix-changes
Merge into: lp://staging/~dbarth/autopilot-gtk/matching-fix
Diff against target: 69 lines (+33/-3)
2 files modified
lib/GtkNode.cpp (+1/-3)
tests/autopilot/tests/test_matching_properties.py (+32/-0)
To merge this branch: bzr merge lp://staging/~allanlesage/autopilot-gtk/suggested-matching-fix-changes
Reviewer Review Type Date Requested Status
David Barth Approve
Review via email: mp+165269@code.staging.launchpad.net

Description of the change

Move test dir to tests as elsewhere in autopilot projects; switch logging to g_debug-style; add autopilot test suite to replicate offered shell-test.

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

The changes look good. Maybe you should also remove the shell script with the tests.

review: Approve
Reply
Revision history for this message
Allan LeSage (allanlesage) wrote :

> The changes look good. Maybe you should also remove the shell script with the
> tests.

David, would you merge this into your branch and maybe make the change you suggest? When you've committed and pushed the change will show up in the original merge proposal, and I'll approve and Jenkins will do its merging work :) . . . .

Reply
Revision history for this message
David Barth (dbarth) wrote :

Le 23/05/2013 21:45, Allan LeSage a écrit :
>> The changes look good. Maybe you should also remove the shell script with the
>> tests.
> David, would you merge this into your branch and maybe make the change you suggest? When you've committed and pushed the change will show up in the original merge proposal, and I'll approve and Jenkins will do its merging work :) . . . .
 I see that you've merged it in the end. Thanks Allan.

David

Reply

Unmerged revisions

44. By Allan LeSage

Add autopilot tests, switch to g_debug logging, move test dir to tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: