Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:check-mm-version into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:snap-20
| Status: | Merged |
|---|---|
| Approved by: | Alfonso Sanchez-Beato |
| Approved revision: | 50bcd566dc363a2784156580e7efda2f01346178 |
| Merged at revision: | d486cc30c55fa6e87869feaf9d48155f761f9f98 |
| Proposed branch: | ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:check-mm-version |
| Merge into: | ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:snap-20 |
| Diff against target: |
99 lines (+70/-0) 4 files modified
snap-common/bin/check-mm-version.sh (+30/-0) snap/hooks/install (+17/-0) snap/hooks/post-refresh (+17/-0) snap/snapcraft.yaml (+6/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Valentin David | Approve | ||
| System Enablement Bot | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Check for ModemManager same or newer than 1.18
We are shipping focal's MM client library in the network-manager
snap. The library will fail if talking to an older verions of MM
daemon than the one for the library, which is an issue as focal has
updated MM from 1.16 to 1.18, so NM would fail to use modems if there
are old versions of the MM snap in the system. To prevent this
problem, check for the MM version in post-refresh and install hooks
and fail if the MM daemon is not modern enough.
Description of the change
Check for ModemManager same or newer than 1.18
We are shipping focal's MM client library in the network-manager
snap. The library will fail if talking to an older verions of MM
daemon than the one for the library, which is an issue as focal has
updated MM from 1.16 to 1.18, so NM would fail to use modems if there
are old versions of the MM snap in the system. To prevent this
problem, check for the MM version in post-refresh and install hooks
and fail if the MM daemon is not modern enough.
| System Enablement Bot (system-enablement-ci-bot) wrote | # |
| Valentin David (valentin.david) wrote | # |
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
PASSED: Continuous integration, rev:70d8c55c286
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
Click here to trigger a rebuild:
https:/