snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:media-hub-snap-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests
  3. media-hub-snap-tests
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 21073781ecc62fd2dcb8201c38518a59e9ea94c6
Merged at revision: a1a36cba7542b6256af48b6f4b819ad6d4a09d70
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:media-hub-snap-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 83 lines (+77/-0)
1 file modified
media-hub/units/media-hub-snap.pxu (+77/-0)
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+320210@code.staging.launchpad.net

Commit message

Add tests for media-hub snap

This test checks that the (confined) media-hub snap can play music
jointly with the mediaplayer-app snap.

Description of the change

Add tests for media-hub snap

This test checks that the (confined) media-hub snap can play music
jointly with the mediaplayer-app snap.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:59c640ab2be18f557090fe25ae5033177af1b98d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1348/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/547
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1256/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1182
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/202

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1348/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, some things to change inline below.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@jhodapp, thanks for the comments. Branch refreshed after addressing changes.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:21073781ecc62fd2dcb8201c38518a59e9ea94c6
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1364/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/633
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1272/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/1265
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/283/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1364/rebuild

review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches