Merge ~alfonsosanchezbeato/network-manager/+git/ubuntu:add-missing-deps into network-manager:snap-1.10

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: f5ffc914c256d8008b48127095e76d1962624af6
Merged at revision: ca61fdd369dd1f37c5ad9f71debd906f93790170
Proposed branch: ~alfonsosanchezbeato/network-manager/+git/ubuntu:add-missing-deps
Merge into: network-manager:snap-1.10
Diff against target: 13 lines (+2/-0)
1 file modified
snap/snapcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Tony Espy Approve
Network-manager Pending
Review via email: mp+358224@code.staging.launchpad.net

Description of the change

Add some missing dependencies to the snap

To post a comment you must log in.
Revision history for this message
Tony Espy (awe) wrote :

While I do see a failure with cleanbuild (using snapcraft 3.0) without iptables or gtk-doc-tools, I don't see any error related to libnss3-dev?

review: Needs Information
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Tony, thanks for double-checking, I have removed libnss3-dev.

Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches