Code review comment for ~alfonsosanchezbeato/network-manager:test-ci
Revision history for this message
| Tony Espy (awe) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
8a78608
demo site
(Get the code!)
I'm not clear if this commit is temporary or not? Did you mean to check this in so that you could test your CI changes, or are these changes intended to be permanent so that we can build the snap using CI? Do we disable a similar set of tests in the old HWE nm build too?
If these changes are intended to be permanent, please add some more detail to your commit message. Something like:
snap: disable tests that fail lp builds
Some advanced integration tests (e.g. bonding, teaming, ...) that are trigged by 'make test' fail when NM is built by launchpad.