Merge ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: 0f7c73da1e278c10669946e218fe73603ed29f98
Merged at revision: f1da282a92a14a98f563200f1d8e5f2d9213f5aa
Proposed branch: ~alfonsosanchezbeato/network-manager:test-ci
Merge into: network-manager:snap-1.10
Diff against target: 157 lines (+92/-16)
4 files modified
.gitignore (+4/-0)
debian/patches/disable-tests-that-fail-under-launchpad-builds.patch (+87/-0)
debian/patches/series (+1/-2)
dev/null (+0/-14)
Reviewer Review Type Date Requested Status
Tony Espy Approve
System Enablement Bot continuous-integration Approve
Review via email:

Commit message

snap: test for CI

Description of the change

snap: test for CI

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tony Espy (awe) wrote :

I'm not clear if this commit is temporary or not? Did you mean to check this in so that you could test your CI changes, or are these changes intended to be permanent so that we can build the snap using CI? Do we disable a similar set of tests in the old HWE nm build too?

If these changes are intended to be permanent, please add some more detail to your commit message. Something like:

snap: disable tests that fail lp builds

Some advanced integration tests (e.g. bonding, teaming, ...) that are trigged by 'make test' fail when NM is built by launchpad.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

It is permanent, otherwise the snap fails the build from launchpad. Yes, we did disable a few tests in the UC16 NM snap.

I have re-worked the commit to be more specific.

Revision history for this message
Tony Espy (awe) wrote :

Thanks for the changes. LGTM!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches