NetworkManager

Merge ~alfonsosanchezbeato/network-manager:add-connectivity-check into network-manager:snap-1.10

  1. Git
  2. lp:~alfonsosanchezbeato/network-manager
  3. add-connectivity-check
  4. Merge into snap-1.10
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Tony Espy
Approved revision: 0f982b528c0173bf44afbc1b9fd8bf30542d537f
Merged at revision: dbce8fd2b1c66678dfafffe84b1a88fd14a0482d
Proposed branch: ~alfonsosanchezbeato/network-manager:add-connectivity-check
Merge into: network-manager:snap-1.10
Diff against target: 264 lines (+52/-19)
7 files modified
dev/null (+0/-11)
snap-common/bin/networkmanager (+9/-0)
snap-common/bin/snap-config.sh (+25/-0)
snap-common/bin/snap-prop.sh (+6/-0)
snap-common/etc/NetworkManager/NetworkManager.conf (+3/-2)
snap/hooks/configure (+9/-0)
snap/snapcraft.yaml (+0/-6)
Reviewer Review Type Date Requested Status
Tony Espy Approve
Network-manager Pending
Review via email: mp+361245@code.staging.launchpad.net

Commit message

* Remove duplicated configure hook
* Adapt dns options to UC series
* Allow installation on UC16 as dns is not an issue anymore
* Add support for connectivity check via ubuntu core options
* Disable MAC randomization feature
* Remove obsoleted no-system-libraries attribute from snapcraft.yaml

Description of the change

* Remove duplicated configure hook
* Adapt dns options to UC series
* Allow installation on UC16 as dns is not an issue anymore
* Add support for connectivity check via ubuntu core options
* Disable MAC randomization feature
* Remove obsoleted no-system-libraries attribute from snapcraft.yaml

To post a comment you must log in.
Revision history for this message
Tony Espy (awe) :
review: Needs Fixing
Revision history for this message
Tony Espy (awe) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Tony, thanks for the review! See my comments below.

Revision history for this message
Tony Espy (awe) wrote :

LGTM

review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Note, I'm not able to successfully build this version using the latest stable version of snapcraft. This may be due to virtualization, as I'm building from Ubuntu running under Parallels w/nested virtualization enabled (to allow multipass to run). Perhaps this is because the Parallels VM instance itself isn't configured in a way which allow all of the test cases to be run?

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@Tony, it is probably that - I have come also into trouble when trying to build in a virtualized environment. Probably we should run the unit tests in CI only and not in snapcraft's build stage.

Revision history for this message
Tony Espy (awe) wrote :

@Alfonso

To do so would mean we need to add CI support for the NM 1.10 snap. We'll talk about it during the product sprint this week, and can follow up at our sprint next week.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches