Media Hub

Merge lp://staging/~alfonsosanchezbeato/media-hub/get-selected-streams into lp://staging/media-hub

  1. get-selected-streams
  2. Merge into trunk
Proposed by Alfonso Sanchez-Beato
Status: Merged
Merged at revision: 156
Proposed branch: lp://staging/~alfonsosanchezbeato/media-hub/get-selected-streams
Merge into: lp://staging/media-hub
Diff against target: 291 lines (+119/-11) (has conflicts)
6 files modified
debian/changelog (+15/-4)
debian/control (+1/-0)
src/core/media/CMakeLists.txt (+2/-0)
src/core/media/gstreamer/engine.cpp (+22/-5)
src/core/media/gstreamer/playbin.cpp (+72/-2)
src/core/media/gstreamer/playbin.h (+7/-0)
Text conflict in debian/changelog
To merge this branch: bzr merge lp://staging/~alfonsosanchezbeato/media-hub/get-selected-streams
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+266251@code.staging.launchpad.net

Commit message

Gather information about missing codecs and selected streams from gstreamer
so we have more information on whether we should play the video or not (LP: #1417950).

Description of the change

Gather information about missing codecs and selected streams from gstreamer
so we have more information on whether we should play the video or not (LP: #1417950).

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few suggestions below. I like the general direction of this approach. Are you planning on adding anything else to it or is this it?

review: Needs Fixing (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Comments addressed. @Jim, yes, for the moment this is it until we modify media-hub's DBus interface so we can transmit more information to the client like:

* Available tracks with type and description
* Information on which tracks can be played and which not due to missing codecs
* A way to select the tracks to play
* An intermediate state in which we can access to this information but we are still not playing (gstreamer state for the stream would be "paused"). Maybe we can move to that state when media is set instead of moving from the initial gstreamer state to playing when the DBus play() method is invoked.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

See my comments below.

review: Needs Fixing (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Comments addressed

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks great, thanks. Let me know when you have this in a silo and I'll help test this well.

review: Approve (code)
lp://staging/~alfonsosanchezbeato/media-hub/get-selected-streams updated
149. By Alfonso Sanchez-Beato

Gather information about missing codecs and selected streams from gstreamer
so we have more information on whether we should play the video or not.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches