Media Hub

Merge lp://staging/~alfonsosanchezbeato/media-hub/get-dim-from-caps into lp://staging/media-hub

  1. get-dim-from-caps
  2. Merge into trunk
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 215
Merged at revision: 216
Proposed branch: lp://staging/~alfonsosanchezbeato/media-hub/get-dim-from-caps
Merge into: lp://staging/media-hub
Diff against target: 34 lines (+21/-3)
1 file modified
src/core/media/gstreamer/playbin.cpp (+21/-3)
To merge this branch: bzr merge lp://staging/~alfonsosanchezbeato/media-hub/get-dim-from-caps
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
Review via email: mp+318373@code.staging.launchpad.net

Commit message

Use caps instead of custom properties to retrieve video dimensions

Description of the change

Use caps instead of custom properties to retrieve video dimensions

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Were you able to test this on the phone as well?

Some changes needed inline below.

review: Needs Fixing (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

See below, repushing too.

lp://staging/~alfonsosanchezbeato/media-hub/get-dim-from-caps updated
215. By Alfonso Sanchez-Beato

Add const to GstStructure

Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Tested on Meizu Pro 5 and for desktop, works as expected in both cases.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches