Merge lp://staging/~alfonsosanchezbeato/media-hub/fix-refs into lp://staging/media-hub/stable
Proposed by
Alfonso Sanchez-Beato
| Status: | Merged |
|---|---|
| Approved by: | Simon Fels |
| Approved revision: | 157 |
| Merged at revision: | 157 |
| Proposed branch: | lp://staging/~alfonsosanchezbeato/media-hub/fix-refs |
| Merge into: | lp://staging/media-hub/stable |
| Diff against target: |
86 lines (+27/-15) 1 file modified
src/core/media/gstreamer/playbin.cpp (+27/-15) |
| To merge this branch: | bzr merge lp://staging/~alfonsosanchezbeato/media-hub/fix-refs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jim Hodapp (community) | code | Approve | |
| Simon Fels | Approve | ||
|
Review via email:
|
|||
Commit message
Avoid getting additional references for audio_sink, which were not being freed. Also, remove unneeded unrefs that must be performed in gstreamer instead.
Description of the change
Avoid getting additional references for audio_sink, which were not being freed. Also, remove unneeded unrefs that must be performed in gstreamer instead.
To post a comment you must log in.
Revision history for this message
| Simon Fels (morphis) | # |
review:
Approve
Revision history for this message
| Simon Fels (morphis) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Tested with silo 28 on arale. No leaking file descriptors anymore.
Used test script:
$ while true ; do ls -1 /proc/`pidof media-hub-
While playing different media files with video player and music-app.