MAAS

Merge ~alexsander-souza/maas/+git/maas-release-tools:better_snap_integration into ~maas-committers/maas/+git/maas-release-tools:main

  1. Git
  2. lp:~alexsander-souza/maas/+git/maas-release-tools
  3. better_snap_integration
  4. Merge into main
Proposed by Alexsander de Souza
Status: Merged
Approved by: Alexsander de Souza
Approved revision: fa4242a274bc8f6ae0f40807fa17a1ae5c06f403
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~alexsander-souza/maas/+git/maas-release-tools:better_snap_integration
Merge into: ~maas-committers/maas/+git/maas-release-tools:main
Prerequisite: ~alexsander-souza/maas/+git/maas-release-tools:integration_test_fix_howto
Diff against target: 465 lines (+207/-123)
3 files modified
maas_release_tools/scripts/release_status.py (+37/-121)
maas_release_tools/snapstore.py (+169/-0)
maas_release_tools/version.py (+1/-2)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Christian Grabowski Approve
Review via email: mp+448199@code.staging.launchpad.net

This proposal supersedes a proposal from 2023-08-02.

Commit message

improve Snapstore integration

implements macaroon refresh

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b better_snap_integration lp:~alexsander-souza/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools

STATUS: SUCCESS
COMMIT: 5f25cd02a4a879d906ca2ab436a49a81ff1c2254

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

Nice!

Maybe we could also encapsulate the actual API calls into methods in the Snapstore class, so that the caller doesn't need to know the details?

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b better_snap_integration lp:~alexsander-souza/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools

STATUS: SUCCESS
COMMIT: 74b647f5227a71f0677a97281f86ca8c682d0b54

review: Approve
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

> Nice!
>
> Maybe we could also encapsulate the actual API calls into methods in the
> Snapstore class, so that the caller doesn't need to know the details?

done

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b better_snap_integration lp:~alexsander-souza/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools

STATUS: SUCCESS
COMMIT: 809fe1463542e775b88389d2dff3fb254e06559c

review: Approve
Revision history for this message
Christian Grabowski (cgrabowski) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b better_snap_integration lp:~alexsander-souza/maas/+git/maas-release-tools into -b main lp:~maas-committers/maas/+git/maas-release-tools

STATUS: SUCCESS
COMMIT: fa4242a274bc8f6ae0f40807fa17a1ae5c06f403

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches