lp:~alexmurray/review-tools

Author: Alex Murray
Author Date: 2023-09-21 23:54:21 UTC

reviewtools/sr_common.py: add missing comma 😳

Thanks @emitorino for the heads up.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-06-19 03:39:57 UTC

sr_lint.py: allow # in URLs (as used in anchor elements)

This allows things like https://github.com/radareorg/radare2#community as seen
in https://dashboard.snapcraft.io/snaps/radare2/revisions/2443/

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-06-16 00:56:22 UTC

overrides.py: add overrides for core24-desktop

These are based on core22-desktop - also update the publisher override for both
snaps to canonical_desktop as this is more appropriate.

https://warthogs.atlassian.net/browse/SEC-2258

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-06-13 12:30:23 UTC

store.py: support filtering USN notifications by pocket/series

This allows to specify say --ignore-pockets=esm-infra/bionic so that we still
send notifications for packages in esm-infra/xenial but not say bionic.

https://warthogs.atlassian.net/browse/SEC-2202

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-06-06 07:41:03 UTC

.launchpad.yaml: fix functest-system job

snaps can't see /build (which is where lpci runs the job) so instead bind mount
this into $HOME as this can be read via the home interface.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-06-06 07:17:20 UTC

snap: use execstack binary from the standard focal package

execstack works as expected on focal so we can just use the execstack package
via stage-packages, rather than trying to build and use the one from xenial (as
this doesn't work anymore). Fixes LP: #2023003

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-05-31 12:13:32 UTC

.launchpad.yaml: add test for functest-system to test the snap

make functest-system uses the system-installed review-tools snap for tests so
wire this up so we get some CI of the snap itself.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-05-31 06:35:24 UTC

snapcraft.yaml: set PYTHONPATH explicitly for staged packages

To fix LP: #2021942

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-05-29 00:53:49 UTC

sr_lint.py: accept tilde (~) as a valid URL character

Fixes LP: #2020903

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-05-17 05:05:06 UTC

sr_lint.py: appease flake8 regex checks

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-04-21 05:47:29 UTC

Merge branch 'master' into update-for-latest-snapd-on-edge-2.59+git716.gcfef182

Author: Alex Murray
Author Date: 2023-04-21 01:02:58 UTC

.launchpad.yaml, REAME: s/lpcraft/lpci/

lpcraft has been renamed lpci

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-04-14 00:30:17 UTC

sr_lint.py: cleanup check_mpris_slot_name() as per review comments

Also update check-names.list as a result

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-03-27 06:19:55 UTC

sr_lint.py: implement stricter checks on disallowed layout paths

/lib is /usr/lib on usrmerge'd systems (same for /var/run -> /run) so add
additional checks for these.

Also the previous code would fail for prefixes like /lib/modules and would
compare /lib against /lib/modules and so would fail to find cases like this, so
add a test case for multi-level components as well.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-02-28 23:54:21 UTC

overrides.py: Add microovn to canonical publisher overrides

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-02-22 03:49:08 UTC

sr_lint.py: Handle case of snap yaml with invalid slots

As seen in https://dashboard.snapcraft.io/snaps/crypto-watcher/revisions/2/
which has the following relevant bits in the snap.yaml:

apps:
  crypto-watcher:
    slots:
    - dbus-crypto-watcher
slots:
  bus: session
  dbus-crypto-watcher: null
  interface: dbus
  name: com.kranthi.crypto-watcher

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-02-02 23:32:24 UTC

tests/test_sr_lint.py: Reformat with black

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-02-02 05:41:58 UTC

tests: Add unit tests for ignore_pockets changes

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-01-24 04:33:10 UTC

.launchpad.yaml: Check the test environment works as expected

Before running the tests, check that unsquashing a snap with privileged contents
works as expected - and if not fail early with guidance on how to fix it. This
should help with running lpcraft locally.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-01-24 01:56:59 UTC

sr_common.py: Remove ancient activatable property from dbus slot

This is not used anymore and never really was by snapd so remove it.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2023-01-23 20:05:45 UTC

sr_lint.py: Bump maximum number of layouts to 100

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-12-09 03:33:51 UTC

Merge branch 'master' into launchpad-yaml-for-ci

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-11-23 03:09:00 UTC

overrides.py: Add core22-desktop fc cache to base_state_files_overrides

These change on each rebuild of the snap so should be ignored.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-11-03 20:56:49 UTC

overrides.py: update with latest Canonical published snaps

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-10-25 08:37:58 UTC

overrides.py: Add setuid binary for zoom-client

See https://forum.snapcraft.io/t/please-allow-the-shipping-of-a-suid-binary-for-chrome-sandbox-and-browser-support-sandboxing-for-zoom-client/32328

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-10-11 10:33:06 UTC

Update check-names.list and tests/test.sh.expected for new tests

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-09-28 04:07:07 UTC

Add ovn-chassis to publisher overrides

See https://forum.snapcraft.io/t/change-of-publisher-ovn-chassis/31940/2

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-09-16 00:39:19 UTC

reviewtools/overrides.py: Another variant of libx264.so to execstack

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-07-28 04:59:39 UTC

tests/test_sr_declaration.py: Remove unnecessary trailing commas

flake8 doesn't like these and they are not needed.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-05-30 03:16:30 UTC

common.py: Output external symlink targets

As requested in LP: #1953358 when detecting symlinks that point outside of
the snap, also output the target which they point to. As a result of this
change also then update the various unit tests etc to cope with this new
output style.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-05-26 06:52:37 UTC

Add mediatek-aiot-kernel to publisher overrides

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-05-03 07:54:18 UTC

data/snapd-base-declaration.yaml: Update for steam-support interface

This was introduced in snapd 2.55.4

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-05-03 06:30:17 UTC

overrides.py: Update for steam snap

This is published by the Desktop team.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-05-03 06:23:37 UTC

overrides.py: Update for latest kernel changes

Kernel team contacts have changed plus a new kernel exists which is
published by Canonical (kdrp-k4500-nxp-kernel) for which notifications
should go to the kernel HWE team.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-04-12 06:04:25 UTC

Update for latest snapd interfaces

- Update base declaration to match snapd 2.54.4/2.55.3
- Update interfaces_attribs in sr_common.py for latest snapd changes
- Add slot-snap-id as an allowed slot attribute for a snap installation
  constraint in sr_declaration.py

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-04-08 00:18:44 UTC

Add support shared-memory private plug attribute

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-03-17 06:51:04 UTC

overrides.py: Add snap-store-proxy to Canonical publisher overrides

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-02-28 11:01:27 UTC

overrides.py: Add snapd-desktop-integration to publisher overrides

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-02-17 01:43:06 UTC

reviewtools/sr_lint.py: Address review feedback from emitorino

Rename this check as conflicting, rather than mutually exclusive,
interfaces for better readability, plus refactor code to avoid copy-pasta
etc.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-02-08 06:25:33 UTC

reviewtools/common.py: Update to handle squashfs-tools 4.5

unsquashfs from squashfs-tools 4.5 does not include the header in the
unsquashfs -lln output. Update the parsing code to handle this and updatet
the unit test to check for it as well.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-02-07 03:33:12 UTC

overrides.py: Add canonical-livepatch to publisher overrides

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-01-06 23:32:18 UTC

overrides.py: Add slack's chrome-sandbox to sec_mode_overrides

The strictly confined slack snap now includes the chromium sandbox which is
setuid root so we need an entry for this in sec_mode_overrides.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2022-01-05 01:26:47 UTC

Update sr_common for shared-memory slot attribute

Otherwise a number of the unit tests fail since the shared-memory attribute
is unknown, e.g. from
https://launchpad.net/~myapps-reviewers/+snap/review-tools/+build/1632720/+files/buildlog_snap_ubuntu_bionic_amd64_review-tools_BUILDING.txt.gz

======================================================================
ERROR: test_verify_snap_declaration_empty (test_sr_declaration.TestSnapDeclarationVerify)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/review-tools/parts/review-tools/build/reviewtools/sr_declaration.py", line 1454, in verify_snap_declaration
    SnapReviewDeclaration._verify_declaration(review, base_decl, base=True)
  File "/build/review-tools/parts/review-tools/build/reviewtools/sr_declaration.py", line 587, in _verify_declaration
    alt, decl, key, iface, index, allowed, (len(alternates) > 1)
  File "/build/review-tools/parts/review-tools/build/reviewtools/sr_declaration.py", line 339, in verify_constraint
    malformed(bn, "unknown attribute '%s'" % attrib, base)
  File "/build/review-tools/parts/review-tools/build/reviewtools/sr_declaration.py", line 254, in malformed
    raise SnapDeclarationException(err)
reviewtools.sr_declaration.SnapDeclarationException: "base declaration malformed (unknown attribute 'shared-memory')"

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2021-12-02 01:05:51 UTC

reviewtools/overrides.py: Fix external symlinks for microsoft-edge

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2021-11-17 00:11:21 UTC

Update snapd-base-declaration from snapd 2.53.2

Author: Alex Murray
Author Date: 2021-11-11 02:03:37 UTC

Fix snap-check-notices handling of snapcraft 5.0 snaps

When analysing a snap built with snapcraft 5.0, snap-check-notices calls
out to snap-updates-available to get a JSON formatted dict of
data. However, when parsing the snap manifest, if a snapcraft version such
as 5.0 is encountered, this is considered an invalid debian package version
and so the output:

WARN: Invalid Snapcraft version: '5.0' not a valid Debian version

is included in the stderr output from snap-updates-available along with any
actual JSON and this causes the JSON parsing in snap-updates-available to
fail as seen in LP: #1950476.

Fixes: LP: #1950476

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2021-11-01 05:43:01 UTC

tests/manual-lzo[-part2].sh: Update for core22 base snap

Author: Alex Murray
Author Date: 2021-10-01 06:07:27 UTC

overrides.py: Add edgex-ui to publisher overrides

Published by Canonical EdgeX team

Author: Alex Murray
Author Date: 2021-09-03 07:50:25 UTC

data/snapd-base-declaration.yaml: Update for latest changes in snapd

Adds ion-memory-control, microstack-support, sd-control and
snap-refresh-control

Author: Alex Murray
Author Date: 2021-07-06 01:00:48 UTC

test-statefulness: Fix the unsquashfs -lln test

unsquashfs -lln shows timestamps in the local systems timezone so make sure
we set TZ so this matches the expected output - also the indentation of the
columns seems to have changed so adjust that too.

Signed-off-by: Alex Murray <alex.murray@canonical.com>

Author: Alex Murray
Author Date: 2021-06-30 13:08:39 UTC

Teach json schema about daemon-scope

Author: Alex Murray
Author Date: 2021-06-27 00:53:22 UTC

snap: Add git to build-packages and truncate version to keep snapcraft happy

Author: Alex Murray
Author Date: 2021-06-23 01:23:45 UTC

Add desktop-launch to snapd-base-declaration.yaml

Author: Alex Murray
Author Date: 2021-06-07 00:19:02 UTC

Add ubuntu-desktop-installer snap to overrides for canonical_desktop

Author: Alex Murray
Author Date: 2021-06-03 01:22:14 UTC

Fix file-extension for resquash to be .lln

Author: Alex Murray
Author Date: 2021-05-28 08:15:40 UTC

sr_common.py: Update for dsp slot flavor property

Author: Alex Murray
Author Date: 2021-05-27 04:37:21 UTC

Add xlnx-config to overrides for classic snaps with slots

As per https://forum.snapcraft.io/t/request-classic-confinement-for-xlnx-config/23926/22?

Author: Alex Murray
Author Date: 2021-04-12 03:13:33 UTC

Update snapd-base-declaration to add new pwm interface

Author: Alex Murray
Author Date: 2021-04-01 06:23:48 UTC

reviewtools: Validate install-mode

Author: Alex Murray
Author Date: 2021-03-26 08:09:55 UTC

run-helper: Set PYTHONPATH to appease newer versions of pylint

Otherwise when running pylint against bin/snap-review it fails:

bin/snap-review:3:0: E0401: Unable to import 'reviewtools' (import-error)
bin/snap-review:14:0: E0401: Unable to import 'reviewtools.common' (import-error)

Author: Alex Murray
Author Date: 2021-03-19 06:48:06 UTC

Add openstackclients to overrides

Author: Alex Murray
Author Date: 2020-10-21 04:04:08 UTC

usn.py: Add focal to tracked_releases

This ensures we process USNs from core20 base snaps (LP: #1900101)

Author: Alex Murray
Author Date: 2020-07-30 01:13:43 UTC

reviewtools/overrides.py: Add personal-files override for krita

Author: Alex Murray
Author Date: 2019-10-23 01:52:20 UTC

overrides.py: Add ngrok

Author: Alex Murray
Author Date: 2019-10-23 00:35:15 UTC

reviewtools/common.py: Add eoan and focal to OS_RELEASE_MAP