QA Regression Testing

Merge ~alexmurray/qa-regression-testing:update-test-gcc-security-for-lp-2007544 into qa-regression-testing:master

  1. Git
  2. lp:~alexmurray/qa-regression-testing
  3. update-test-gcc-security-for-lp-2007544
  4. Merge into master
Proposed by Alex Murray
Status: Merged
Merged at revision: 96ab14c5c8dd1454292b6ee289464c167a7b430e
Proposed branch: ~alexmurray/qa-regression-testing:update-test-gcc-security-for-lp-2007544
Merge into: qa-regression-testing:master
Diff against target: 95 lines (+25/-8)
1 file modified
scripts/test-gcc-security.py (+25/-8)
Reviewer Review Type Date Requested Status
Ubuntu Security Team Pending
Steve Beattie Pending
Review via email: mp+437462@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Pavel Kopylov (pkopylov) wrote :

Great, it has worked fine for me on these systems: Ubuntu 16.04, Ubuntu 18.04, and Ubuntu 20.04.

Revision history for this message
Steve Beattie (sbeattie) wrote :

Apologies, I've not reviewed this in any depth, but one nit:

On Fri, Feb 17, 2023 at 12:56:17AM -0000, Alex Murray wrote:
> + # Backtrace expected? glibc removed this functionality
> + # (https://github.com/bminor/glibc/commit/a289ea09ea843ced6e5277c2f2e63c357bc7f9a3)

Not sure what that github repo is, but the official glibc git repo link
for this commit would be:

  https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=a289ea09ea843ced6e5277c2f2e63c357bc7f9a3

> + # but even before this it was broken since 2017 due to a bug in
> + # https://github.com/bminor/glibc/commit/ed421fca42fd9b4cab7c66e77894b8dd7ca57ed0

and similarly

  https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=ed421fca42fd9b4cab7c66e77894b8dd7ca57ed0

--
Steve Beattie
<email address hidden>

Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks sbeattie - I have fixed those links up in https://git.launchpad.net/~alexmurray/qa-regression-testing/commit/?id=a3598bc48def5d2dc882be07bbb6c94b89a6686b

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches