Juju Charms Collection
nova-compute package

Merge lp://staging/~alexlist/charms/trusty/nova-compute/nonstandard-authkeys-path into lp://staging/~openstack-charmers-archive/charms/trusty/nova-compute/next

  1. Trusty Tahr (14.04)
  2. nonstandard-authkeys-path
  3. Merge into next
Proposed by Alexander List
Status: Merged
Merged at revision: 89
Proposed branch: lp://staging/~alexlist/charms/trusty/nova-compute/nonstandard-authkeys-path
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/nova-compute/next
Diff against target: 115 lines (+38/-7)
5 files modified
config.yaml (+9/-0)
hooks/nova_compute_hooks.py (+2/-0)
hooks/nova_compute_utils.py (+12/-7)
unit_tests/test_nova_compute_hooks.py (+9/-0)
unit_tests/test_nova_compute_utils.py (+6/-0)
To merge this branch: bzr merge lp://staging/~alexlist/charms/trusty/nova-compute/nonstandard-authkeys-path
Reviewer Review Type Date Requested Status
Liam Young Pending
Review via email: mp+243159@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-11-28.

Description of the change

Allow configuring nonstandard authorized_keys path, including unit test, take two

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote : Posted in a previous version of this proposal

This looks good to me but please add a unit test(s) to test the new feature

review: Needs Fixing
Revision history for this message
James Page (james-page) wrote : Posted in a previous version of this proposal

Please set back to 'Needs review' once unit tests added.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

UOSCI bot says:
charm_lint_check #1255 nova-compute-next for alexlist mp243152
    LINT FAIL: lint-test failed

LINT Results (max last 5 lines):
INFO:root:command: make -f Makefile lint
ERROR:root:Make target returned non-zero.
  hooks/nova_compute_utils.py:408:1: E302 expected 2 blank lines, found 1
  unit_tests/test_nova_compute_hooks.py:333:25: E225 missing whitespace around operator
  make: *** [lint] Error 1

Full lint test output: http://paste.ubuntu.com/9282789/
Build: http://10.98.191.181:8080/job/charm_lint_check/1255/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

UOSCI bot says:
charm_unit_test #1089 nova-compute-next for alexlist mp243152
    UNIT OK: passed

UNIT Results (max last 5 lines):
  nova_compute_hooks 134 13 90% 79, 99-100, 127, 193, 251, 256-257, 263, 267-270
  nova_compute_utils 230 106 54% 161-217, 225, 230-233, 268-270, 277, 281-284, 292-300, 304, 313-322, 335-354, 410-431, 448-458, 472-473, 478-479
  TOTAL 570 189 67%
  Ran 59 tests in 3.143s
  OK (SKIP=5)

Full unit test output: http://paste.ubuntu.com/9282790/
Build: http://10.98.191.181:8080/job/charm_unit_test/1089/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

UOSCI bot says:
charm_amulet_test #558 nova-compute-next for alexlist mp243152
    AMULET OK: passed

AMULET Results (max last 5 lines):
  juju-test.conductor.15-basic-trusty-icehouse RESULT :
  juju-test.conductor DEBUG : Tearing down osci-sv07 juju environment
  juju-test.conductor DEBUG : Calling "juju destroy-environment -y osci-sv07"
  WARNING cannot delete security group "juju-osci-sv07-0". Used by another environment?
  juju-test INFO : Results: 3 passed, 0 failed, 0 errored

Full amulet test output: http://paste.ubuntu.com/9283017/
Build: http://10.98.191.181:8080/job/charm_amulet_test/558/

Revision history for this message
Liam Young (gnuoy) wrote : Posted in a previous version of this proposal

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches