Unity

Merge lp://staging/~alexlauni/unity/introspection-search-cleanup into lp://staging/unity

  1. introspection-search-cleanup
  2. Merge into trunk
Proposed by Alex Launi
Status: Rejected
Rejected by: Alex Launi
Proposed branch: lp://staging/~alexlauni/unity/introspection-search-cleanup
Merge into: lp://staging/unity
Prerequisite: lp://staging/~alexlauni/unity/debgging-gchar-to-stdstring
Diff against target: 50 lines (+7/-8)
1 file modified
plugins/unityshell/src/DebugDBusInterface.cpp (+7/-8)
To merge this branch: bzr merge lp://staging/~alexlauni/unity/introspection-search-cleanup
Reviewer Review Type Date Requested Status
Tim Penhey (community) Needs Information
Review via email: mp+81919@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-11-08.

Description of the change

Makes some slight changes to the introspection search method.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

I think a simple test case should exist for the behaviour of this method.

Should be relatively trivial to add to the tests directory using google test.

The FindPieceToIntrospect(std::string const& peiceName); // don't forget the &

Should this method handle dotted names?

Like 'launcher.child' or something?

review: Needs Information

Unmerged revisions

1744. By Alex Launi

Fix introspection piece search

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.