Merge lp://staging/~alecu/unity8-desktop-session/click-scope-show-desktop-apps into lp://staging/unity8-desktop-session

Proposed by Alejandro J. Cura
Status: Work in progress
Proposed branch: lp://staging/~alecu/unity8-desktop-session/click-scope-show-desktop-apps
Merge into: lp://staging/unity8-desktop-session
Diff against target: 11 lines (+1/-0)
1 file modified
data/unity8-mir.conf.in (+1/-0)
To merge this branch: bzr merge lp://staging/~alecu/unity8-desktop-session/click-scope-show-desktop-apps
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Review via email: mp+215023@code.staging.launchpad.net

Commit message

Force unity-scope-click to show desktop applications

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Does the code that need this environment variable run in the Unity8 process space or as a child process?

review: Needs Information
Revision history for this message
Alejandro J. Cura (alecu) wrote :

> Does the code that need this environment variable run in the Unity8 process
> space or as a child process?

AFAIK it's ran as child process.

The code using this env var is the click scope, which is a shared library loaded by the scope-runner process, which in turn is started by the scope-registry process. These processes are independent of the Unity8 process.

Revision history for this message
Alejandro J. Cura (alecu) wrote :

> Does the code that need this environment variable run in the Unity8 process
> space or as a child process?

After reading the upstart docs, I realized the clue in this question :-)

I'm now pushing a fixed branch.

48. By Alejandro J. Cura

Make the env var available to child processes, and not only to unity8

Revision history for this message
Alejandro J. Cura (alecu) wrote :

And now I was able to test it and see the installed desktop apps.
Bad news is that there are quite a few icons that show up empty.

Revision history for this message
Stephen M. Webb (bregma) wrote :

Sweet. Let's get this merged.

review: Approve

Unmerged revisions

48. By Alejandro J. Cura

Make the env var available to child processes, and not only to unity8

47. By Alejandro J. Cura

Force unity-scope-click to show desktop applications

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches