unity-scopes-api

Merge lp://staging/~alecu/unity-scopes-api/table-widget-docs into lp://staging/unity-scopes-api

  1. table-widget-docs
  2. Merge into trunk
Proposed by Alejandro J. Cura
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 278
Merged at revision: 349
Proposed branch: lp://staging/~alecu/unity-scopes-api/table-widget-docs
Merge into: lp://staging/unity-scopes-api
Prerequisite: lp://staging/~marcustomlinson/unity-scopes-api/lp-1410125
Diff against target: 41 lines (+24/-0)
1 file modified
src/scopes/PreviewWidget.cpp (+24/-0)
To merge this branch: bzr merge lp://staging/~alecu/unity-scopes-api/table-widget-docs
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Michi Henning (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Paweł Stołowski Pending
Review via email: mp+246556@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-01-15.

Commit message

Add docs for the table widget

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote : Posted in a previous version of this proposal

Thanks for that! Looks good, but I would reword one sentence:

> \arg \c values An array with as many entries as rows desired. Each entry is an array of two strings: label and value

It'll read better as:

\arg \c values An array with one element per row. Each entry is an array of two strings: label and value.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:276
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/511/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/36/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/36/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/511/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote : Posted in a previous version of this proposal

Apologies for this failure, it is caused by a change in json-cpp. You can get rid of the failure by merging this branch: https://code.launchpad.net/~marcustomlinson/unity-scopes-api/lp-1410125/+merge/246264

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:277
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/515/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/40/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/40/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/515/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:277
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/529/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-amd64-ci/54
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/54
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-armhf-ci/54/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-vivid-i386-ci/54

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/529/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

I just noticed that this has been sitting here for a long time. Is there any reason we can't merge it?

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good to me, one thing that would be good to include is that when the table is inside a non expanded Expandable only 3 rows at most are shown.

review: Needs Fixing
lp://staging/~alecu/unity-scopes-api/table-widget-docs updated
278. By Alejandro J. Cura

When used inside an Expandable widget, the topmost 3 rows are shown until it's expanded.

Revision history for this message
Alejandro J. Cura (alecu) wrote :

I've added a line explaining what happens when used inside an Expandable widget.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:278
http://jenkins.qa.ubuntu.com/job/unity-scopes-api-ci/634/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-wily-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-wily-armhf-ci/22
        deb: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-wily-armhf-ci/22/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scopes-api-wily-i386-ci/22

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scopes-api-ci/634/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michi Henning (michihenning) wrote :

Albert, if you are happy with this, can you top-approve please?

review: Approve
Revision history for this message
Albert Astals Cid (aacid) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: