Music Lens

Merge lp://staging/~alecu/unity-lens-music/silence-notifications into lp://staging/unity-lens-music

  1. silence-notifications
  2. Merge into trunk
Proposed by Alejandro J. Cura
Status: Needs review
Proposed branch: lp://staging/~alecu/unity-lens-music/silence-notifications
Merge into: lp://staging/unity-lens-music
Diff against target: 157 lines (+75/-15)
3 files modified
src/musicstore-scope.vala (+38/-15)
src/ubuntuone-webservices.vala (+14/-0)
tests/unit/test-ubuntuone-purchases.vala (+23/-0)
To merge this branch: bzr merge lp://staging/~alecu/unity-lens-music/silence-notifications
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+167874@code.staging.launchpad.net

Commit message

Update the text of the notifications on error

Description of the change

Update the text of the notifications on error

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:140
http://jenkins.qa.ubuntu.com/job/unity-lens-music-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-music-ci/10/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Alejandro J. Cura (alecu) wrote :

This branch changes the text of the "performing purchase" notification, right at the moment any error happens:

When the purchase fails:
http://ubuntuone.com/5n1T5viEW9ttNOCwcFG4Lx

When the password is wrong:
http://ubuntuone.com/0eF2usg4CRunxko5SCcfcI

Reply
lp://staging/~alecu/unity-lens-music/silence-notifications updated
141. By Alejandro J. Cura

merged with trunk

142. By Alejandro J. Cura

merge lp:~alecu/unity-lens-music/sign-opened-urls

143. By Alejandro J. Cura

merged from sign-open-urls

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:142
http://jenkins.qa.ubuntu.com/job/unity-lens-music-ci/13/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-armhf-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-music-ci/13/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:143
http://jenkins.qa.ubuntu.com/job/unity-lens-music-ci/15/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-armhf-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-lens-music-saucy-i386-ci/7

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-music-ci/15/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

143. By Alejandro J. Cura

merged from sign-open-urls

142. By Alejandro J. Cura

merge lp:~alecu/unity-lens-music/sign-opened-urls

141. By Alejandro J. Cura

merged with trunk

140. By Alejandro J. Cura

update notifications on error

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: