Merge lp://staging/~alecu/ubuntuone-client/restrain-out-of-space-dialog-1-4 into lp://staging/ubuntuone-client/stable-1-4
Proposed by
Alejandro J. Cura
| Status: | Rejected | ||||
|---|---|---|---|---|---|
| Rejected by: | dobey | ||||
| Proposed branch: | lp://staging/~alecu/ubuntuone-client/restrain-out-of-space-dialog-1-4 | ||||
| Merge into: | lp://staging/ubuntuone-client/stable-1-4 | ||||
| Diff against target: |
342 lines (+178/-19) 3 files modified
gsd-plugin/gsd-ubuntuone.c (+80/-19) gsd-plugin/gsd-ubuntuone.h (+3/-0) gsd-plugin/test-flood.py (+95/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~alecu/ubuntuone-client/restrain-out-of-space-dialog-1-4 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| dobey (community) | Disapprove | ||
| Natalia Bidart (community) | Approve | ||
|
Review via email:
|
|||
Commit message
don't nag with the out-of-space dialog so often (fixes Bug #650671)
Description of the change
don't nag with the out-of-space dialog so often (fixes Bug #650671)
To post a comment you must log in.
Revision history for this message
| Natalia Bidart (nataliabidart) | # |
review:
Approve
Unmerged revisions
- 745. By Alejandro J. Cura
-
make that once per day
- 744. By Alejandro J. Cura
-
fixes Bug #650671
- 743. By Alejandro J. Cura
-
don't nag with the out-of-space dialog so often
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Aside from my obvious other disagreements with this branch, the trunk version has not landed yet, and theere is this:
Part of the problem is also that the dialog is destroyed and shown again, even if it's already shown. Instead it needs to be in a static variable, and if already shown, simply presented again.